Conversation
zebot
added
the
ok-to-test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures that when a conversation’s access roles no longer include the service/app role, apps are removed from that conversation, aligning membership with updated access constraints.
Changes:
- Update conversation access-role handling to remove bots and app users when
ServiceAccessRoleis not present. - Add an integration test covering app removal when service access is removed (and additional role-removal behavior).
- Add a changelog entry for the bug fix.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| services/galley/src/Galley/API/Action.hs | Filters conversation membership when service access is revoked (bots/apps removal logic). |
| integration/test/Test/Apps.hs | Adds an integration test validating membership changes after access-role updates. |
| changelog.d/3-bug-fixes/WPB-24569-remove-apps-from-convs-when-apps-are-disabled-in-conv | Documents the behavior change in the changelog. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fisx
force-pushed
the
WPB-24569-remove-apps-from-convs-when-apps-are-disabled-in-conv
branch
from
bfbba5b to
7f1f22d
Compare
fisx
force-pushed
the
WPB-24569-remove-apps-from-convs-when-apps-are-disabled-in-conv
branch
from
7f1f22d to
04902e3
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
fisx
commented
Apr 14, 2026
fisx
deleted the
WPB-24569-remove-apps-from-convs-when-apps-are-disabled-in-conv
branch
This was referenced Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d