WPB-24076: Add meeting cleaner job in background-worker#5207
Open
blackheaven wants to merge 7 commits intodevelopfrom
Open
WPB-24076: Add meeting cleaner job in background-worker#5207blackheaven wants to merge 7 commits intodevelopfrom
background-worker#5207blackheaven wants to merge 7 commits intodevelopfrom
Conversation
zebot
added
the
ok-to-test
blackheaven
force-pushed
the
gdifolco/WPB-24076-background-worker-meetings-cleaner
branch
from
1af1c4f to
1df93ce
Compare
battermann
requested changes
Apr 28, 2026
Comment on lines
+40
to
+73
| cleanupOldMeetingsImpl :: | ||
| ( Member Store.MeetingsStore r, | ||
| Member ConvStore.ConversationStore r | ||
| ) => | ||
| UTCTime -> | ||
| Int -> | ||
| Sem r Int64 | ||
| cleanupOldMeetingsImpl cutoffTime batchSize = do | ||
| -- 1. Fetch old meetings | ||
| oldMeetings <- Store.getOldMeetings cutoffTime batchSize | ||
|
|
||
| if null oldMeetings | ||
| then pure 0 | ||
| else do | ||
| -- 2. Extract meeting IDs and conversation IDs | ||
| let meetingIds = map (\Store.StoredMeeting {id = mid} -> mid) oldMeetings | ||
| convIds = map (\Store.StoredMeeting {conversationId = cid} -> cid) oldMeetings | ||
|
|
||
| -- 3. Delete meetings from database | ||
| deletedCount <- Store.deleteMeetingBatch meetingIds | ||
|
|
||
| -- 4. Delete associated conversations if they are meeting conversations | ||
| -- We need to check if conversation has GroupConvType = MeetingConversation | ||
| for_ (zip oldMeetings convIds) $ \(meeting, convId) -> do | ||
| maybeConv <- ConvStore.getConversation convId | ||
| case maybeConv of | ||
| Just conv | ||
| | conv.metadata.cnvmGroupConvType == Just MeetingConversation, | ||
| conv.id_ == convId, | ||
| meeting.conversationId == convId -> | ||
| ConvStore.deleteConversation convId | ||
| _ -> pure () | ||
|
|
||
| pure deletedCount |
Contributor
There was a problem hiding this comment.
I would say it would be better to use the MeetingSubsystem to delete a meeting because that will take care of proper conversation deletion as well via the ConversationSubsystem.
Contributor
There was a problem hiding this comment.
I guess the reason to have it's own logic here is the batch deletion on a DB level. But we should properly remove all conversation related data, so using the MeetingSubsystem is the price we have to pay, IMO.
blackheaven
force-pushed
the
gdifolco/WPB-24076-background-worker-meetings-cleaner
branch
from
1df93ce to
525b82e
Compare
blackheaven
force-pushed
the
gdifolco/WPB-24076-background-worker-meetings-cleaner
branch
from
692ecf7 to
ce1b6b8
Compare
battermann
requested changes
May 5, 2026
|
|
||
| backgroundWorker: | ||
| host: backgroundWorker.{{ .Release.Namespace }}.svc.cluster.local | ||
| host: background-worker.{{ .Release.Namespace }}.svc.cluster.local |
| Just conv | ||
| | conv.metadata.cnvmGroupConvType == Just MeetingConversation, | ||
| conv.id_ == meeting.conversationId -> | ||
| ConvStore.deleteConversation meeting.conversationId |
Contributor
There was a problem hiding this comment.
I still think that we should use the MeetingSubsystem to delete the meeting because that properly cleans up the conversation data. Here AFAICT we only delete the conversation via the ConversationStore but instead we should use the handler from the ConversationSubsystem because that takes care of deleting all the other stuff that is related to a conversation.
Contributor
Author
There was a problem hiding this comment.
We have to pair program on this tomorrow because regular meeting deletion requires a Qualified UserId and a ConnId
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-24076
Checklist
changelog.d