Reset all connections with PostgreSQL when the server restarts#5216
Merged
Conversation
zebot
added
the
ok-to-test
akshaymankar
force-pushed
the
hasql-conn-reset
branch
from
a1251e6 to
0f13c04
Compare
akshaymankar
changed the title
akshaymankar
force-pushed
the
hasql-conn-reset
branch
from
0f13c04 to
54a7143
Compare
akshaymankar
force-pushed
the
hasql-conn-reset
branch
from
54a7143 to
3e7e1bd
Compare
hasql is more strict in parsing data now
Rows affected actually works here, but according to docs it should only be used for update and delete statements.
Both sessions and transactions implement 'MonadIO' hence they can have arbitrary effects, so the user must make an explicit choice to retry these. The pipelines and statements can always be retried.
fisx
reviewed
May 13, 2026
fisx
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-25203
Upstream issue: nikita-volkov/hasql-pool#54
More things to do:
usewith functions fromWire.Postgres.In case case multiple connections realize the need for reset at once, we'd be resetting multiple times, is this really ok?
This is fine because using
releaseonly marks already acquired connections to be released, in case there is a race it can make the racing connections to be released very quickly, but I think its not such a big problem because it would max make the whole pool reconnect once, which isn't so bad.Checklist
changelog.d