Skip to content

fix: Allow personal users to create mls clients [WPB-20129] #19523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
V-Gira merged 1 commit into from
Sep 9, 2025
Merged

fix: Allow personal users to create mls clients [WPB-20129] #19523

V-Gira merged 1 commit into from
Sep 9, 2025

Conversation

@V-Gira
Copy link
Contributor

@V-Gira V-Gira commented Sep 9, 2025 •
edited by github-actions bot
Loading

BugWPB-20129 [Web] Temporary guests do not create MLS client, thus cannot send messages in a MLS group

Description

cherry-pick of c67e441 to the q2-2025 branch
See PR here #19054

Checklist

  • mentions the JIRA issue in the PR name (Ex. [WPB-XXXX])
  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@V-Gira V-Gira requested review from a team and otto-the-bot as code owners September 9, 2025 14:35
@codecov
Copy link

codecov bot commented Sep 9, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (release/q2-2025@3c32168). Learn more about missing BASE report.

Additional details and impacted files 
@@                Coverage Diff                 @@
##             release/q2-2025   #19523   +/-   ##
==================================================
  Coverage                   ?   45.79%           
==================================================
  Files                      ?     1036           
  Lines                      ?    28436           
  Branches                   ?     6386           
==================================================
  Hits                       ?    13021           
  Misses                     ?    13802           
  Partials                   ?     1613
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@otto-the-bot @thisisamir98 @V-Gira
fix: Allow personal users to create mls clients (WPB-17396) (#19053) (#…
2d11e63 
…19054)

* fix: Allow personal users to create mls clients (WPB-17396)

* cleanup

* refactor

* get common

Co-authored-by: Amir Ghezelbash <thisisamir98@gmail.com>
@V-Gira V-Gira force-pushed the v/mls-guest-wpb-20129 branch from 25e7068 to 2d11e63 Compare September 9, 2025 15:48
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 9, 2025

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@V-Gira V-Gira changed the title fix(mls): Establish MLS group conversation when joining with deeplink [WPB-20129] fix: Allow personal users to create mls clients [WPB-20129] Sep 9, 2025
@V-Gira V-Gira merged commit 2cd2d82 into release/q2-2025 Sep 9, 2025
17 checks passed
@V-Gira V-Gira deleted the v/mls-guest-wpb-20129 branch September 9, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aweiss-dev aweiss-dev aweiss-dev approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees

No one assigned

Labels

👕 size: S type: bug / fix 🐞

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@V-Gira @aweiss-dev @otto-the-bot