Skip to content

Conversation

@zskhan
Copy link
Contributor

@zskhan zskhan commented Dec 24, 2025

BugWPB-17002 [Web] Warning when screensharing in fullscreen and trying to go back to minimized view

Pull Request

Summary

Allow customizable container in ModalComponent for modal rendering
Show warning to end screen share only when it is shared from detached mode.

  • What did I change and why?
  • Risks and how to roll out / roll back (e.g. feature flags):

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@zskhan zskhan requested review from a team and otto-the-bot as code owners December 24, 2025 10:47
@zskhan zskhan changed the title feat: allow customizable container in ModalComponent for modal rendering feat: allow customizable container in ModalComponent for modal rendering [WPB-17002] Dec 24, 2025
@codecov
Copy link

codecov bot commented Dec 24, 2025

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 44.64%. Comparing base (401f92b) to head (e4d8f22).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev   #19943      +/-   ##
==========================================
+ Coverage   44.62%   44.64%   +0.01%     
==========================================
  Files        1311     1311              
  Lines       33027    33030       +3     
  Branches     7314     7316       +2     
==========================================
+ Hits        14739    14745       +6     
+ Misses      16538    16535       -3     
  Partials     1750     1750              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zskhan zskhan force-pushed the feat/warning-to-end-screen-sharing branch from 4ed85cc to 82d9460 Compare December 24, 2025 10:55
@zskhan zskhan changed the title feat: allow customizable container in ModalComponent for modal rendering [WPB-17002] feat: allow customizable container in ModalComponent for modal rendering and show end screen sharing warning only on detached window [WPB-17002] Dec 24, 2025
@zskhan zskhan enabled auto-merge (squash) December 24, 2025 10:58
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

github-actions bot commented Dec 24, 2025

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 103
  • Failed: 7
  • Skipped: 11
  • 🔁 Flaky: 8
  • 📊 Total: 129
  • Total Runtime: 356.1s (~ 5 min 56 sec)
specs/Accessibility/Accessibility.spec.ts (❌ 0 failed, ⚠️ 2 flaky)
  • ⚠️ Accessibility > I want to see collapsed view when app is narrow (tags: TC-48, regression)
  • ⚠️ Accessibility > I should not lose a drafted message when switching between conversations in collapsed view (tags: TC-51, regression)
specs/AccountSettingsSpecs/accountSettings.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ account settings > I should not be able to change email of user managed by SCIM (tags: TC-60, regression)
specs/AppLock/AppLock.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ AppLock > Web: App should not lock if I switch back to webapp tab in time (during inactivity timeout) (tags: TC-2752, TC-2753, regression)
specs/ArchiveSpecs/archive.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Accessibility > I want to archive the 1on1 conversation from conversation details (tags: TC-105, regression)
specs/Block/block.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Block: User A and User B are NOT in the same team > Verify you can block a user who is not in your team (tags: TC-140, regression)
specs/CriticalFlow/accountManagement-TC-8639.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Account Management (tags: TC-8639, crit-flow-web)
specs/CriticalFlow/Cells/uploadingFileInGroupConversation.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Uploading an file in a group conversation (tags: crit-flow-cells, regression)
specs/CriticalFlow/messagesIn1On1-TC-8750.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Messages in 1:1 (tags: TC-8750, crit-flow-web)
specs/CriticalFlow/oneOnOneCall-TC-8754.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ 1:1 Video call with device switch and screenshare (tags: TC-8754, crit-flow-web)
specs/CriticalFlow/personalAccountLifecycle-TC-8638.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Personal Account Lifecycle (tags: TC-8638, crit-flow-web)
specs/Edit/edit.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Edit > I can see the changed message was edited from another user (tags: TC-692, regression)
specs/Folders/folders.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Folders > I want to move a 1:1 conversation to an existing custom folder (tags: TC-547, regression)
specs/RegressionSpecs/block-search.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Block from search specs (tags: TC-144, regression)
specs/Reply/reply.spec.ts (❌ 1 failed, ⚠️ 0 flaky)
  • ❌ Reply > I should not be able to send a reply after I got removed from the conversation (tags: TC-3014, regression)

@zskhan zskhan merged commit 67ea540 into dev Dec 24, 2025
13 checks passed
@zskhan zskhan deleted the feat/warning-to-end-screen-sharing branch December 24, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants