-
Notifications
You must be signed in to change notification settings - Fork 297
feat: allow customizable container in ModalComponent for modal rendering and show end screen sharing warning only on detached window [WPB-17002] #19943
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## dev #19943 +/- ##
==========================================
+ Coverage 44.62% 44.64% +0.01%
==========================================
Files 1311 1311
Lines 33027 33030 +3
Branches 7314 7316 +2
==========================================
+ Hits 14739 14745 +6
+ Misses 16538 16535 -3
Partials 1750 1750 🚀 New features to boost your workflow:
|
4ed85cc to
82d9460
Compare
|
thisisamir98
approved these changes
Dec 24, 2025
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/Accessibility/Accessibility.spec.ts (❌ 0 failed,
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Pull Request
Summary
Allow customizable container in ModalComponent for modal rendering
Show warning to end screen share only when it is shared from detached mode.
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers