chore(e2e): Added clearing of search input query to handle retries [WPB-21646] #20377
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rsationFiles.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rsation.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rsation.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rsation.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…rsation.page.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sInGroupConversation-TC-8788.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sInGroupConversation-TC-8788.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sInGroupConversation-TC-8788.spec.ts Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…sInGroupConversation-TC-8788.spec.ts Co-authored-by: Mark Brockhoff <95471369+markbrockhoff@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds/updates Drive-related Playwright E2E coverage to improve reliability around searching files in a Cells-enabled group conversation (WPB-21646), including support utilities/page objects to make the assertions and retries more robust.
Changes:
- Added a new E2E spec for searching files in a group conversation (TC-8788), including clearing the search query between checks.
- Updated Cells page objects to support file search and multipart (image/video) asset locators; adjusted existing Drive specs accordingly.
- Minor E2E maintenance: export
VideoFileName, fix fixtures import paths in Drive specs, and correct the README env-inject command path.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/webapp/test/e2e_tests/utils/asset.util.ts | Exports VideoFileName for reuse in specs. |
| apps/webapp/test/e2e_tests/specs/Drive/uploadingFileInGroupConversation-TC-8785.spec.ts | Fixes fixtures import path; improves assertions/selectors and tags. |
| apps/webapp/test/e2e_tests/specs/Drive/searchFilesInGroupConversation-TC-8788.spec.ts | New spec covering file search in group conversation + query clearing. |
| apps/webapp/test/e2e_tests/specs/Drive/replyingToMultipartMessage-TC-8787.spec.ts | Fixes fixtures import path. |
| apps/webapp/test/e2e_tests/specs/Drive/editMultipartMessage-TC-8786.spec.ts | Fixes fixtures import path. |
| apps/webapp/test/e2e_tests/pageManager/webapp/pages/conversation.page.ts | Makes getImageLocator public for direct test assertions. |
| apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversationFiles.page.ts | Adds search input locator + searchFile(); replaces click helper with getFile(). |
| apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversation.page.ts | Refines image locator strategy; adds multipart image/video locators. |
| apps/webapp/test/e2e_tests/README.md | Updates op inject paths to match repo structure. |
Comment on lines
89
to
90
| await expect(userBPages.cellsConversationFiles().filesList).toHaveCount(1, {timeout: 500}); | ||
| await expect(userBPages.cellsConversationFiles().getFile(VideoFileName)).toBeVisible({timeout: 500}); |
There was a problem hiding this comment.
[Important] - The retry block uses very short per-assertion timeouts (500ms) immediately after filling the search input. In the app, file search is debounced (300ms) and requires a network request, so 500ms can be too tight and make this test flaky even when indexing is fine.
Consider removing the {timeout: 500} overrides (use default expect timeouts) or increasing them while keeping the outer .toPass({timeout: ...}) as the overall cap.
Suggested change
| await expect(userBPages.cellsConversationFiles().filesList).toHaveCount(1, {timeout: 500}); | |
| await expect(userBPages.cellsConversationFiles().getFile(VideoFileName)).toBeVisible({timeout: 500}); | |
| await expect(userBPages.cellsConversationFiles().filesList).toHaveCount(1); | |
| await expect(userBPages.cellsConversationFiles().getFile(VideoFileName)).toBeVisible(); |
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversationFiles.page.ts
Show resolved
Hide resolved
apps/webapp/test/e2e_tests/pageManager/webapp/cells/cellsConversationFiles.page.ts
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #20377 +/- ##
=======================================
Coverage 45.25% 45.25%
=======================================
Files 1633 1633
Lines 40245 40245
Branches 8325 8325
=======================================
Hits 18212 18212
Misses 20105 20105
Partials 1928 1928
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
specs/AppLock/AppLock.spec.ts (❌ 1 failed,
|
cristianoliveira
approved these changes
Feb 11, 2026
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
https://wearezeta.atlassian.net/browse/WPB-21646
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers