Skip to content

refactor: clean up AppLock tests [WPB-22420]#20593

Merged
markbrockhoff merged 3 commits intodevfrom
mb/refactor-AppLock-tests
Mar 9, 2026
Merged

refactor: clean up AppLock tests [WPB-22420]#20593
markbrockhoff merged 3 commits intodevfrom
mb/refactor-AppLock-tests

Conversation

@markbrockhoff
Copy link
Copy Markdown
Collaborator

@markbrockhoff markbrockhoff commented Mar 6, 2026

TaskWPB-22420 [Web] General maintenance ticket for PR merges

Pull Request

Summary

  • Refactor existing test cases for AppLock since they were incomplete and mixed with each other affecting our reporting
  • This PR also removes some outdated and bloated utils which should no longer exist

Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Git got a bit confused by the first commit. It effectively just wraps some of the test in a second describe block to re-use the beforeEach for them, while the second one does the actual refactoring. I recommend to look at the commits individually, this way the second commit is much easier to read.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 206
  • Failed: 0
  • Skipped: 13
  • 🔁 Flaky: 6
  • 📊 Total: 225
  • Total Runtime: 356.1s (~ 5 min 56 sec)
specs/AccountSettings/accountSettings.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ account settings > Verify sound settings are saved after re-login (tags: TC-1718, TC-1720, regression)
specs/Archive/archive.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Archive > I want to archive the 1on1 conversation from conversation details (tags: TC-105, regression)
specs/Authentication/authentication.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Authentication > Verify current browser is set as temporary device (tags: TC-3460, regression)
specs/Ping/ping.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Ping > Verify I see a warning when I ping in a big group (tags: TC-1496, regression)
specs/Reactions/reactions.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Reactions > Verify liking someone's link preview in 1:1 (tags: TC-1527, regression)
specs/SelfDeletingMessages/selfDeletingMessages.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Self Deleting Messages > Verify sending ephemeral text message in 1:1 (tags: TC-657, regression)

@markbrockhoff markbrockhoff force-pushed the mb/refactor-AppLock-tests branch from 09c0d9a to 94735ee Compare March 9, 2026 07:38
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 9, 2026

@markbrockhoff markbrockhoff added this pull request to the merge queue Mar 9, 2026
Merged via the queue into dev with commit 495f756 Mar 9, 2026
101 of 102 checks passed
@markbrockhoff markbrockhoff deleted the mb/refactor-AppLock-tests branch March 9, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants