Skip to content

test: fix flake in conversation search tests [WPB-22420]#20627

Merged
markbrockhoff merged 1 commit intodevfrom
mb/fix-flake-in-conversation-search-test
Mar 10, 2026
Merged

test: fix flake in conversation search tests [WPB-22420]#20627
markbrockhoff merged 1 commit intodevfrom
mb/fix-flake-in-conversation-search-test

Conversation

@markbrockhoff
Copy link
Copy Markdown
Collaborator

@markbrockhoff markbrockhoff commented Mar 9, 2026

TaskWPB-22420 [Web] General maintenance ticket for PR merges

Pull Request

Summary

One of the tests could be come flaky due to network latency when deleting the message right before the other user searches for it. This ensures the message was already deleted for the user before he searches for it.


Security Checklist (required)

  • External inputs are validated & sanitized on client and/or server where applicable.
  • API responses are validated; unexpected shapes are handled safely (fallbacks or errors).
  • No unsafe HTML is rendered; if unavoidable, sanitization is applied and documented where it happens.
  • Injection risks (XSS/SQL/command) are prevented via safe APIs and/or escaping.

Accessibility (required)

Standards Acknowledgement (required)


Screenshots or demo (if the user interface changed)

Notes for reviewers

  • Trade-offs:
  • Follow-ups (linked issues):
  • Linked PRs (e.g. web-packages):

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 9, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 9, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 260
  • Failed: 0
  • Skipped: 16
  • 🔁 Flaky: 4
  • 📊 Total: 280
  • Total Runtime: 495.7s (~ 8 min 16 sec)
specs/Conversations/conversations.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Conversations > I want to see a system message with all group members mentioned on creating a group (tags: TC-2965, regression)
specs/Notifications/notifications.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Notifications > No notification shown when selecting 'Off' in preferences (tags: TC-1453, regression)
specs/Reactions/reactions.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Reactions > Verify likes are reset if you edited message (tags: TC-1538, regression)
specs/SelfDeletingMessages/selfDeletingMessages.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Self Deleting Messages > Verify sending ephemeral text message in 1:1 (tags: TC-657, regression)

@markbrockhoff markbrockhoff added this pull request to the merge queue Mar 10, 2026
Merged via the queue into dev with commit 4dc85b9 Mar 10, 2026
53 checks passed
@markbrockhoff markbrockhoff deleted the mb/fix-flake-in-conversation-search-test branch March 10, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants