fix: Documents in Recycle Bin should not be editable(WPB-23547)#20921
Merged
arjita-mitra merged 2 commits intodevfrom Apr 8, 2026
Merged
fix: Documents in Recycle Bin should not be editable(WPB-23547)#20921arjita-mitra merged 2 commits intodevfrom
arjita-mitra merged 2 commits intodevfrom
Conversation
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
|
screendriver
reviewed
Apr 8, 2026
screendriver
reviewed
Apr 8, 2026
screendriver
reviewed
Apr 8, 2026
…t default in destructuring isEditMode
|
screendriver
approved these changes
Apr 8, 2026
zskhan
pushed a commit
that referenced
this pull request
Apr 14, 2026
* fix: Documents in Recycle Bin should not be editable(WPB-23547) * fix: use dependency injection to test isInRecycleBin and make explicit default in destructuring isEditMode
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Documents that have been moved to the Recycle Bin remain editable when on web. Files in the Recycle Bin should be in a read-only state and not allow further modifications.
Steps to Reproduce
Go to a Wire Drive enabled conversation
Upload an editable document (e.g., .docx)
Move the document to the Recycle Bin
Open the document from the Recycle Bin
Attempt to edit the document
Expected Result
Documents in the Recycle Bin should:
Be read-only / Be on preview-only
No modifications should be possible
Editing capabilities (typing, formatting, saving changes) should be disabled
Security Checklist (required)
Accessibility (required)
Standards Acknowledgement (required)
Screenshots or demo (if the user interface changed)
Notes for reviewers