Skip to content

test: improve reliability of history backup test [WPB-22420]#21152

Merged
markbrockhoff merged 1 commit into
devfrom
mb/improve-reliability-of-history-backup
May 11, 2026
Merged

test: improve reliability of history backup test [WPB-22420]#21152
markbrockhoff merged 1 commit into
devfrom
mb/improve-reliability-of-history-backup

Conversation

@markbrockhoff
Copy link
Copy Markdown
Collaborator

@markbrockhoff markbrockhoff commented Apr 27, 2026

TaskWPB-22420 [Web] General maintenance ticket for PR merges

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

If the deletion of the group conversation in TC-1097 took too long it could happen that it was still included within the created backup.

Solutions

This PR waits for the conversation to be no longer visible before creating the backup to make it more reliable.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

zhannach
zhannach previously approved these changes Apr 27, 2026
@markbrockhoff markbrockhoff enabled auto-merge April 27, 2026 11:08
zskhan
zskhan previously approved these changes Apr 29, 2026
@markbrockhoff markbrockhoff force-pushed the mb/improve-reliability-of-history-backup branch from 4a8d090 to c71985f Compare May 8, 2026 12:09
If the deletion of the group conversation in TC-1097 took too long it could happen that it was still included within the created backup. This PR waits for the conversation to be no longer visible before creating the backup to make it more reliable.
@markbrockhoff markbrockhoff dismissed stale reviews from zskhan, zhannach, and JacquelineLehner via 23de802 May 8, 2026 12:10
@markbrockhoff markbrockhoff force-pushed the mb/improve-reliability-of-history-backup branch from c71985f to 23de802 Compare May 8, 2026 12:10
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 14
  • Failed: 0
  • Skipped: 0
  • 🔁 Flaky: 1
  • 📊 Total: 15
  • Total Runtime: 136.7s (~ 2 min 17 sec)
specs/CriticalFlow/groupCalls-TC-8632.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Planning group call with sending various messages during call (tags: TC-8632, crit-flow-web)

@markbrockhoff markbrockhoff requested a review from zskhan May 8, 2026 12:51
@markbrockhoff markbrockhoff added this pull request to the merge queue May 8, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 8, 2026
@markbrockhoff markbrockhoff added this pull request to the merge queue May 11, 2026
Merged via the queue into dev with commit d944f13 May 11, 2026
34 checks passed
@markbrockhoff markbrockhoff deleted the mb/improve-reliability-of-history-backup branch May 11, 2026 07:07
screendriver pushed a commit that referenced this pull request May 15, 2026
…ory-backup

test: improve reliability of history backup test [WPB-22420]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants