test: Add missing regression test for editing replies [WPB-24828]#21167
Merged
Conversation
JacquelineLehner
force-pushed
the
test/24828-write-missing-reply-test
branch
2 times, most recently
from
6addb8c to
5d1ce6b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #21167 +/- ##
=======================================
Coverage 44.95% 44.95%
=======================================
Files 1704 1704
Lines 44838 44838
Branches 9379 9379
=======================================
Hits 20157 20157
Misses 22387 22387
Partials 2294 2294
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
JacquelineLehner
requested review from
arjita-mitra,
e-maad,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
markbrockhoff
requested changes
May 8, 2026
This commit completes the regression test coverage for the Reply functionality by implementing TC-3019. The test verifies: - Sending a message and receiving a reply from another user. - The unread reply indicator appears in the conversation list. - A user can successfully edit their reply message. - A user can edit the original message, and the quote inside the reply accurately reflects these changes. - Interacting with edited URLs inside quoted replies correctly opens them in a new tab. To support these assertions, the page objects were updated: - `conversation.page.ts`: Added `replyQuoteBoxAboveMessageInputField` to verify the quote preview UI disappears during editing. - `conversationList.page.ts`: Added `unreadReplyIndicator` to assert the visibility of the new reply notification icon. Refs: WPB-24828
…C-3019) - Added intermediate `toBeVisible()` assertions after sending/editing messages to ensure the UI state is fully synced and to prevent race conditions. - Fixed a locator issue by removing the `sender` property and adding `.first()` when verifying a user's own outgoing messages - Added an explicit wait to ensure the transient "deleted" placeholder (`You cannot see this message`) disappears before asserting the updated quote text, eliminating flakiness. Refs: WPB-24828
…abilize assertions Refs: WPB-24828
Refs: WPB-22420
… message' since it was only needed to investigate a bug Refs: WPB-24828
…url in the quotes message' since it was only needed to investigate a bug Refs: WPB-24828
JacquelineLehner
force-pushed
the
test/24828-write-missing-reply-test
branch
from
5d1ce6b to
6e6b002
Compare
|
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
|
markbrockhoff
approved these changes
May 8, 2026
zskhan
approved these changes
May 8, 2026
screendriver
pushed a commit
that referenced
this pull request
May 15, 2026
…-test test: Add missing regression test for editing replies [WPB-24828]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Submission Checklist for internal contributors
The PR Title
SQPIT-764The PR Description
What's new in this PR?
Issues
The regression test suite was missing a test for the reply flow, specifically for TC-3019: I want to edit my reply.
NOTE: As discussed with @iskvortsov, the test is currently skipped due to flakiness. The underlying issue is tracked in WPB-25411.
Solutions
This PR implements the missing automated test for
TC-3019.It ensures users can successfully edit replies and that the UI accurately reflects edits to both replies and original quoted messages. The implemented scenario verifies:
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.