fix: show correct system message when disabling self deleting messages [WPB-22420]#21233
Merged
Merged
Conversation
…s [WPB-22420] This reverts a [change](https://github.com/wireapp/wire-webapp/pull/21203/changes#diff-6a7d2709a05a0aa3f0e20d913b37f6edd3449395be5bbb13e1673c585de4bda6R3100) made in #21203 which changed the behavior of this message type by passing `0` as empty value instead of `null` causing the wrong system message to be printed. This fixes the regression test TC-3720 for self deleting messages.
markbrockhoff
requested review from
arjita-mitra,
e-maad,
otto-the-bot,
screendriver,
thisisamir98 and
zskhan
as code owners
|
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
|
JacquelineLehner
approved these changes
May 5, 2026
screendriver
approved these changes
May 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
screendriver
pushed a commit
that referenced
this pull request
May 15, 2026
…s [WPB-22420] (#21233) This reverts a [change](https://github.com/wireapp/wire-webapp/pull/21203/changes#diff-6a7d2709a05a0aa3f0e20d913b37f6edd3449395be5bbb13e1673c585de4bda6R3100) made in #21203 which changed the behavior of this message type by passing `0` as empty value instead of `null` causing the wrong system message to be printed. This fixes the regression test TC-3720 for self deleting messages.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts a change made in #21203 which changed the behavior of this message type by passing
0as empty value instead ofnullcausing the wrong system message to be printed. This fixes the regression test TC-3720 for self deleting messages.