fix: add null checks for call in getGrid and updateVideoGrid functions [WPB-25267]#21240
Merged
Merged
Conversation
zskhan
requested review from
arjita-mitra,
e-maad,
otto-the-bot,
screendriver and
thisisamir98
as code owners
thisisamir98
previously approved these changes
May 5, 2026
Contributor
|
🔗 Download Full Report Artifact 🧪 Playwright Test Summary
|
screendriver
reviewed
May 5, 2026
Co-authored-by: Christian Rackerseder <git@echooff.de>
|
screendriver
reviewed
May 6, 2026
thisisamir98
approved these changes
May 6, 2026
e-maad
approved these changes
May 6, 2026
screendriver
approved these changes
May 6, 2026
github-merge-queue Bot
pushed a commit
that referenced
this pull request
May 6, 2026
* chore: Update translations * chore: use github hoster runners for jobs (#20910) * chore: trigger push * chore(E2E): Updated calling service API client to use 1Password [WPB-24489] (#20905) * chore: Update translations * chore: Update translations * chore: Revert "fix: Search results are not fetching all files when the search box is empty(WPB-20817) (#21066)" chore: Revert "fix: Search results are not fetching all files when the search box is empty(WPB-20817) (#21066)" * chore: Update translations chore: Update translations * chore: Update translations * fix: add null checks for call in getGrid and updateVideoGrid functions * Apply suggestion from @screendriver Co-authored-by: Christian Rackerseder <git@echooff.de> --------- Co-authored-by: Amir Ghezelbash <thisisamir98@gmail.com> Co-authored-by: Immad Abdul Jabbar <immad.jabbar@wire.com> Co-authored-by: Ivan Skvortsov <ivan.skvortsov@wire.com> Co-authored-by: Christian Rackerseder <git@echooff.de> Co-authored-by: Zafar Saeed Khan <zafarsaeed@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add null checks for call in getGrid and updateVideoGrid.
Previously it was throwing exception when the call is undefined.