Skip to content

ensure mls conversation is established when joining with guest link [WPB-22305]#21264

Merged
zskhan merged 1 commit into
devfrom
fix-join-with-guest-link
May 8, 2026
Merged

ensure mls conversation is established when joining with guest link [WPB-22305]#21264
zskhan merged 1 commit into
devfrom
fix-join-with-guest-link

Conversation

@thisisamir98
Copy link
Copy Markdown
Collaborator

@thisisamir98 thisisamir98 commented May 8, 2026

StoryWPB-22305 [Web] Joining MLS conversation by guest link doesn't produce welcome message

Before trying to add other self clients to the MLS conversation upon joining with guest link we need to make sure the current self client joins the conversation by external commit first

Before trying to add other self clients to the MLS conversation upon joining with guest link we need to make sure the current self client joins the conversation by external commit first
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented May 8, 2026

Copy link
Copy Markdown
Member

@MohamadJaara MohamadJaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@thisisamir98 thisisamir98 enabled auto-merge May 8, 2026 10:39
@thisisamir98 thisisamir98 added this pull request to the merge queue May 8, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 8, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 15
  • Failed: 0
  • Skipped: 0
  • 🔁 Flaky: 0
  • 📊 Total: 15
  • Total Runtime: 101.1s (~ 1 min 41 sec)

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 8, 2026
@zskhan zskhan added this pull request to the merge queue May 8, 2026
Merged via the queue into dev with commit f183fa9 May 8, 2026
35 checks passed
@zskhan zskhan deleted the fix-join-with-guest-link branch May 8, 2026 17:15
screendriver pushed a commit that referenced this pull request May 15, 2026
ensure mls conversation is established when joining with guest link [WPB-22305]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants