Skip to content

Disable poor quality banner [WPB-25911]#21411

Merged
zskhan merged 2 commits into
masterfrom
feat/disable-poor-connection-banner
Jun 1, 2026
Merged

Disable poor quality banner [WPB-25911]#21411
zskhan merged 2 commits into
masterfrom
feat/disable-poor-connection-banner

Conversation

@zskhan
Copy link
Copy Markdown
Contributor

@zskhan zskhan commented Jun 1, 2026

BugWPB-25911 [Web/AVS] Fine tuning internet connection quality indicator

Disable poor connection quality banner

e-maad
e-maad previously approved these changes Jun 1, 2026
@zskhan zskhan changed the base branch from dev to master June 1, 2026 09:26
@zskhan zskhan dismissed e-maad’s stale review June 1, 2026 09:26

The base branch was changed.

@zskhan zskhan changed the title Disable poor quality banner Disable poor quality banner [WPB-25911] Jun 1, 2026
@e-maad e-maad self-requested a review June 1, 2026 09:42
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jun 1, 2026

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 45.71%. Comparing base (8fe31f1) to head (2c88fb6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21411      +/-   ##
==========================================
- Coverage   45.73%   45.71%   -0.02%     
==========================================
  Files        1696     1696              
  Lines       43686    43685       -1     
  Branches     9095     9095              
==========================================
- Hits        19979    19972       -7     
- Misses      21445    21451       +6     
  Partials     2262     2262              
Flag Coverage Δ
app_webapp 43.89% <ø> (-0.02%) ⬇️
lib_api_client 51.74% <ø> (ø)
lib_core 59.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...c/script/repositories/calling/CallingRepository.ts 31.91% <ø> (-0.63%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zskhan zskhan added this pull request to the merge queue Jun 1, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2026

🔗 Download Full Report Artifact

🧪 Playwright Test Summary

  • Passed: 364
  • Failed: 0
  • Skipped: 15
  • 🔁 Flaky: 10
  • 📊 Total: 389
  • Total Runtime: 5743.1s (~ 95 min 43 sec)
specs/Calling/calling.spec.ts (❌ 0 failed, ⚠️ 6 flaky)
  • ⚠️ Calling > Late joiner wants to see the ongoing screen sharing on group call (tags: TC-2874, regression)
  • ⚠️ Calling > Verify leaving and coming back to the group call (tags: TC-2808, regression)
  • ⚠️ Calling > I want to see warning when calling a big group (tags: TC-2842, regression)
  • ⚠️ Calling > I want to accept a group video call as a personal account guest (tags: TC-2852, regression)
  • ⚠️ Calling > As a moderator I want to mute another participant (tags: TC-2928, regression)
  • ⚠️ Calling > I want to unmute myself after I got muted (tags: TC-2931, regression)
specs/ClearConversationContent/clearConversationContent.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Clear Conversation Content > I want to see incoming picture, ping and call after I clear content of a group conversation via conversation list (tags: TC-156, regression)
specs/CriticalFlow/channelsCall-TC-8755.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Calls in channels with device switch and screenshare (tags: TC-8755, crit-flow-web)
specs/Guestroom/guestroom.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Guestroom > I want to join a conversation through password secured invite link as existing user (tags: TC-8140, regression)
specs/Status/status.spec.ts (❌ 0 failed, ⚠️ 1 flaky)
  • ⚠️ Status > When I am Busy, I should not get any notifications for certain messages (text, file, video, audio, ping, images, link preview, system messages) (tags: TC-3614, regression)

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 1, 2026
@zskhan zskhan merged commit fded281 into master Jun 1, 2026
225 of 233 checks passed
@zskhan zskhan deleted the feat/disable-poor-connection-banner branch June 1, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants