Skip to content

Implement turret ConVars#2702

Merged
thegrb93 merged 8 commits into
wiremod:masterfrom
Hazeofdream:turret-convars
Aug 3, 2023
Merged

Implement turret ConVars#2702
thegrb93 merged 8 commits into
wiremod:masterfrom
Hazeofdream:turret-convars

Conversation

@Hazeofdream
Copy link
Copy Markdown
Contributor

Fixes #2592 and makes certain wire turret options convars instead of having bias against multiplayer sessions.

Copy link
Copy Markdown
Contributor

@vurvdev vurvdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No stealth buffs :p

At least put in your PR description if you intend to make limits more lax to ask if it is okay to do so

Comment thread lua/entities/gmod_wire_turret.lua Outdated
Comment thread lua/entities/gmod_wire_turret.lua Outdated
Comment thread lua/wire/stools/turret.lua Outdated
@Hazeofdream
Copy link
Copy Markdown
Contributor Author

haha that works too

@vurvdev vurvdev changed the title Implement ConVars Implement turret ConVars Jul 31, 2023
@thegrb93
Copy link
Copy Markdown
Contributor

thegrb93 commented Aug 2, 2023

I'm fine with the buffs, they can be turned down by servers who don't want it.

The one thing I'm not sure of is the values in 'NumSlider'. is it min,max,default? Some of the defaults look weird if so.

@vurvdev
Copy link
Copy Markdown
Contributor

vurvdev commented Aug 2, 2023

Only thing was numbullets which I saw disabling would allow someone to set a turret to spawn infinite bullets, but now it's force clamped so. Turrets being able to shoot 5x faster is a pretty big buff though

@Hazeofdream
Copy link
Copy Markdown
Contributor Author

ultimately, wire can only be regulated properly by the server owners, wiremod's attempts to but in on their behalf is either unwelcome or won't work

@Hazeofdream
Copy link
Copy Markdown
Contributor Author

The one thing I'm not sure of is the values in 'NumSlider'. is it min,max,default? Some of the defaults look weird if so.

apparently the last value is an optional decibel value, so some values like 0 on damage means no decimal damage. They still look wack though

@thegrb93
Copy link
Copy Markdown
Contributor

thegrb93 commented Aug 3, 2023

Ah ok

@thegrb93 thegrb93 merged commit ff059c2 into wiremod:master Aug 3, 2023
@Hazeofdream Hazeofdream deleted the turret-convars branch August 3, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Turret there are no some settings in multiplayer

3 participants