Skip to content

Comments

Throw explained lambda error (#3130 #3308)#3333

Merged
Denneisk merged 12 commits intowiremod:masterfrom
UnitLabs:pullreq-fix-lambda
Jun 2, 2025
Merged

Throw explained lambda error (#3130 #3308)#3333
Denneisk merged 12 commits intowiremod:masterfrom
UnitLabs:pullreq-fix-lambda

Conversation

@Zvbhrf
Copy link
Contributor

@Zvbhrf Zvbhrf commented May 27, 2025

Fixes #3130 and #3308

(Sorry, I messed commit history a bit :P)

Copy link
Member

@Denneisk Denneisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still a supporter for the previous compiler writer's reason for not including this check, but I won't be too resistant if people still want it.

@Zvbhrf
Copy link
Contributor Author

Zvbhrf commented May 28, 2025

I'm still a supporter for the previous compiler writer's reason for not including this check, but I won't be too resistant if people still want it.

I've already been confused a few times (I thought I found a bug) until I opened the compiler.lua file and Wiremods issues.
I decided to add an error which say for sure: something is wrong in your lambda, not in the compiler itself.
We must remember that there are many of players who don't know Lua and that GitHub exists. They will probably be more confused than I am when getting Lua errors during compilation.

@Denneisk Denneisk merged commit a08b336 into wiremod:master Jun 2, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simple compiler bug

2 participants