fix: save running timer segment when quitting the app - #28
Merged
Conversation
Quit (menu item and in-app button) called NSApplication.terminate directly, bypassing TimerManager.stop() — the only path that persists the in-progress segment to SessionStore. AppDelegate had no applicationWillTerminate hook, so any time tracked since the last save point was silently lost on quit. Mirrors the existing systemWillSleep handler, which already flushes the timer on sleep/screensaver for the same reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NSApplication.terminatedirectly, bypassingTimerManager.stop()— the only code path that persists the in-progress segment toSessionStore.AppDelegatehad noapplicationWillTerminatehook, so any time tracked since the last save point was silently discarded on quit.applicationWillTerminate(_:)callingTimerManager.shared.stop(reason: "App quit"), mirroring the existingsystemWillSleephandler that already does this for sleep/screensaver.Test plan
swift build— cleanswift test— 40/40 passing