Node.JS dependency version requirement mismatch breaks Cloudflare deployments

[ethrx]

Astro Info

Astro                    v5.6.1
Node                     v22.13.1
System                   Windows (x64)
Package Manager          npm
Output                   static
Adapter                  @astrojs/cloudflare
Integrations             @astrojs/react
                         @astrojs/sitemap
                         astro-robots-txt
                         @astrojs/partytown
                         astro-compressor

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

The package yocto-spinner is listed in dependencies in packages/db/package.json has listed a higher version of node in their package.json:

"engines": {
  "node": ">=18.19"
},

https://github.com/sindresorhus/yocto-spinner/blob/main/package.json

As noted in the quick checklist and https://docs.astro.build/en/install-and-setup/, the minimum supported Node.JS version is v18.17.1.

Cloudflare is set to use v18.17.1 on deployments.
https://developers.cloudflare.com/pages/configuration/build-image#supported-languages-and-tools

So when you try and deploy with cloudflare without setting your NODE_VERSION to one higher than the minimum Astro recommends:

22:08:51.118 | Installing project dependencies: npm clean-install --progress=false
-- | --
22:08:52.027 | npm WARN EBADENGINE Unsupported engine {
22:08:52.027 | npm WARN EBADENGINE   package: 'yocto-spinner@0.2.1',
22:08:52.027 | npm WARN EBADENGINE   required: { node: '>=18.19' },
22:08:52.027 | npm WARN EBADENGINE   current: { node: 'v18.17.1', npm: '9.8.1' }

You can find a similar description of this issue here:
sveltejs/kit#12464

What's the expected result?

Astro downgrades the package or updates the minimum node version.

Link to Minimal Reproducible Example

Not aplicable

Participation

• I am willing to submit a pull request for this issue.

[florian-lefebvre]

Cc @ascorbic that may be annoying if we plan to bump the minimum node version in 5.8

[ascorbic]

Well that's annoying. I'll ask if they have plans to increase the default.

[zanhk]

I brought that up some time ago, here s the chat

https://discord.com/channels/830184174198718474/1339616204838535169/1339631874502557788

@ethrx meanwhile you should be able to build without forcing the engine check

[ascorbic]

I've spoken with them, and they should have a new version of the build image ready before the end of the month that updates the default, because of Node 18 EOL.

[florian-lefebvre]

We bumped the minimum supported node version in 5.8 so this is not an issue anymore

[yuvadm]

@florian-lefebvre not quite sure what that means, a 5.8.0 project still generates:

"engines": {
    "node": "18.20.8 || ^20.3.0 || >=22.0.0"
}

and thus fails on Cloudflare pages without setting NODE_VERSION

[florian-lefebvre]

Indeed but it is not a problem on Astro side anymore, it is on Cloudflare side (for pages) to update their minimal node version. This is explained at the end of https://astro.build/blog/astro-580/