@astrojs/cloudflare dependency on deprecated @cloudflare/workers-types breaks Env typing in monorepos

[calumpeak]

Astro Info

Astro                    v5.3.0
Node                     v24.7.0
System                   macOS (arm64)
Package Manager          npm
Output                   server
Adapter                  @astrojs/cloudflare
Integrations             @clerk/astro/integration
                         @astrojs/starlight
                         @astrojs/react
                         @astrojs/mdx

If this issue only occurs in one browser, which browser is a problem?

No response

Describe the Bug

When running a monorepo with other cloudflare wrangler (v4) applications, if a package installs the deprecated @cloudflare/workers-types package (if the other packages have migrated off it and use wrangler types), it breaks the typing for the other applications by Env being unable to resolve causing type errors through the other applications.

Package a -> installs wrangler -> wrangler types -> outputs worker-configuration.d.ts -> all Env typing is correct
Package b -> installs @astrojs/cloudflare (dependency on @cloudflare/workers-types) -> installs dependencies -> Pakage a's typing is broken for Env (Env = any)

Note: the reproduction will need to be pulled down locally and npx wrangler types run in packages/app to view issue. Remove astrojs/cloudflare from the docs package and notice how the type errors dissapear in the app package.

What's the expected result?

@astrojs/cloudflare should not have a deprecated package in its dependencies which can break typing for other packages and overwrite typing.

Link to Minimal Reproducible Example

https://stackblitz.com/edit/sb1-61xgrc2f?file=packages%2Fapp%2Fwrangler.toml

Participation

• I am willing to submit a pull request for this issue.

[matthewp]

For Astro 6 I'd propose that we:

• Remove @cloudflare/workers-types as a direct dependency and move to devDep.
• Once wrangler supports configless worker types run that as part of astro sync
• We already add a default wrangler config for people using astro add so very few people will be affected by this.

[ocavue]

It's weird that I cannot reproduce the "(Env = any)" issue. Here is my step-by-step reproduction. Every command is successful. Not sure what I missed.

❯ git clone https://github.com/issueset/astro-cf-type-issue
❯ cd astro-cf-type-issue
❯ git --no-pager log --oneline -n 1
05d6d82 (HEAD -> master, origin/master, origin/HEAD) astro-cf-type-issue
❯ npm --version
11.6.2
❯ node --version
v24.11.1
❯ npm ci
❯ cd packages/app
❯ npx wrangler types

 ⛅️ wrangler 4.41.0 (update available 4.60.0)
─────────────────────────────────────────────
Generating project types...

declare namespace Cloudflare {
        interface Env {
                EXAMPLE_VAR: "Hello from environment variables";
                EXAMPLE_VAR2: "Hello2 from environment variables";
        }
}
interface Env extends Cloudflare.Env {}

Generating runtime types...

Runtime types generated.

────────────────────────────────────────────────────────────
✨ Types written to worker-configuration.d.ts

📖 Read about runtime types
https://developers.cloudflare.com/workers/languages/typescript/#generate-types
📣 Remember to rerun 'wrangler types' after you change your wrangler.toml file.


❯ nr typecheck && echo "Okey...." # typecheck is passed
Okey....
❯ cd ../..
❯ cd packages/docs
❯ cat package.json # astrojs/cloudflare is installed here
{
  "name": "@monorepo/docs",
  "type": "module",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "dev": "astro dev",
    "build": "astro build",
    "preview": "astro preview"
  },
  "dependencies": {
    "@astrojs/cloudflare": "^12.6.12",
    "@astrojs/starlight": "^0.30.3",
    "astro": "^5.2.5",
    "sharp": "^0.33.5"
  }
}
❯

[calumpeak]

@florian-lefebvre has this been completed?

[florian-lefebvre]

Yes this works in v6 beta

[calumpeak]

Brill thanks - I'll check the beta out.