Configure celeste-text-generation for PyPI publication#21
Configure celeste-text-generation for PyPI publication#21Kamilbenkirane merged 1 commit intomainfrom
Conversation
- Rename package from 'text-generation' to 'celeste-text-generation' to avoid PyPI conflict - Update optional dependencies to reference celeste-text-generation - Add workspace source configuration for celeste-text-generation - Update publish workflow to build all workspace packages (--all-packages)
Pull Request Review: Configure celeste-text-generation for PyPI publicationSummaryThis PR configures the workspace to properly publish both ✅ Strengths
🔍 Issues & Concerns1. Critical: Version Synchronization ProblemSeverity: High Both packages share version
Recommendation: - name: Validate workspace versions
run: |
ROOT_VERSION=$(python3 -c "import tomllib; print(tomllib.load(open('pyproject.toml', 'rb'))['project']['version'])")
for pkg in packages/*/pyproject.toml; do
PKG_VERSION=$(python3 -c "import tomllib; print(tomllib.load(open('$pkg', 'rb'))['project']['version'])")
PKG_NAME=$(python3 -c "import tomllib; print(tomllib.load(open('$pkg', 'rb'))['project']['name'])")
if [ "$PKG_VERSION" != "$ROOT_VERSION" ]; then
echo "Version mismatch: $PKG_NAME has $PKG_VERSION but root has $ROOT_VERSION"
exit 1
fi
done2. Missing: Update Environment URLsSeverity: Medium The publish workflow environments still only reference # publish.yml:85, 104
url: https://test.pypi.org/project/celeste-ai/
url: https://pypi.org/project/celeste-ai/Recommendation: 3. Potential Issue: Dependency Version ConstraintSeverity: Low The root text-generation = ["celeste-text-generation>=0.1.0"]This allows any version Recommendation: text-generation = ["celeste-text-generation==0.1.0"]Or use compatible release clause: text-generation = ["celeste-text-generation~=0.1.0"] # >=0.1.0, <0.2.04. Missing: Test CoverageSeverity: Medium No tests verify:
Recommendation: 5. Documentation: Update Installation InstructionsSeverity: Low The README in 🔒 Security Considerations✅ No security concerns identified. The changes:
⚡ Performance Considerations✅ No performance impact. Changes are configuration-only. 🧪 Test CoverageSuggested tests:
📋 Code Quality & Best Practices✅ Good:
🎯 RecommendationConditional Approval - The PR is functionally correct but has important gaps:
Additional NotesThe change from Consider whether you want both packages to always be released together (current approach) or if they should have independent release cycles. If independent, you will need more sophisticated workflow logic. |
This PR configures the
celeste-text-generationpackage for PyPI publication:text-generationtoceleste-text-generationto avoid PyPI name conflictpyproject.tomlto referenceceleste-text-generationuvknows it's a workspace package--all-packagesflagWhen a tag is pushed, both
celeste-aiandceleste-text-generationwill be built and published to PyPI.