Skip to content

chore: bump version to 0.1.1#22

Closed
Kamilbenkirane wants to merge 1 commit intomainfrom
bump-version-0.1.1
Closed

chore: bump version to 0.1.1#22
Kamilbenkirane wants to merge 1 commit intomainfrom
bump-version-0.1.1

Conversation

@Kamilbenkirane
Copy link
Copy Markdown
Member

Bump version to 0.1.1 to include optional dependencies configuration in published package.

This version will include:

  • Optional dependencies for text-generation and all extras
  • Updated workflow to build all workspace packages
  • Package renamed to celeste-text-generation

After merging, the tag v0.1.1 will trigger the publish workflow.

- Update version in root pyproject.toml
- Update version in text-generation package
- This version includes optional dependencies configuration
@claude
Copy link
Copy Markdown

claude Bot commented Nov 7, 2025

Pull Request Review: Version Bump to 0.1.1

Overview

This PR bumps the version from 0.1.0 to 0.1.1 for both the root package (celeste-ai) and the celeste-text-generation workspace package. The changes are minimal and focused solely on version numbers.


Code Quality and Best Practices

✅ Positive:

  • Clean, minimal changes focused on a single concern (version bumping)
  • Follows conventional commits style with chore: prefix
  • Both packages are bumped in sync, maintaining consistency

⚠️ Suggestions:

  1. Optional Dependency Version Constraint Issue

    • In pyproject.toml:36-37, the optional dependencies are specified as:
      text-generation = ["celeste-text-generation>=0.1.0"]
      all = ["celeste-text-generation>=0.1.0"]
    • This uses >=0.1.0 which means any version >= 0.1.0 will satisfy the dependency, including 0.1.0 itself
    • Since this PR is bumping to 0.1.1, consider whether the constraint should be updated to >=0.1.1 to ensure users get the latest version with the fixes/features mentioned in the PR description
    • Recommendation: Update to celeste-text-generation>=0.1.1 if 0.1.1 contains important fixes that should be required
  2. Missing CHANGELOG

    • No CHANGELOG.md file exists in the repository
    • The publish workflow (.github/workflows/publish.yml:133-144) generates a changelog from git commits, but maintaining a structured CHANGELOG would improve transparency
    • Recommendation: Consider adding a CHANGELOG.md following Keep a Changelog format

Potential Bugs or Issues

⚠️ Potential Issue: Version Constraint Mismatch

The root package's optional dependency constraint may allow installation of version 0.1.0 of celeste-text-generation even after this version bump. This could cause issues if:

Questions to verify:

  • Does celeste-text-generation version 0.1.1 have any breaking changes or critical fixes that require updating the constraint?
  • Should users be able to install celeste-ai==0.1.1 with celeste-text-generation==0.1.0?

Performance Considerations

✅ No performance impact - This is purely a version number change with no code modifications.


Security Concerns

✅ No security issues identified - The changes only modify version strings in metadata files.


Test Coverage

⚠️ Observations:

  1. No New Tests Required - Since this is a version bump, no new test coverage is needed
  2. CI Validation - The publish workflow includes validation that the git tag matches the pyproject.toml version (.github/workflows/publish.yml:31-37), which is good
  3. Integration Tests - The workflow runs integration tests before publishing, ensuring the package works correctly

✅ Recommendation: Ensure CI passes before merging, particularly:

  • Format checks
  • Linting
  • Type checking
  • Unit tests with 90% coverage requirement
  • Integration tests (when the tag is created)

Versioning Consistency Check

✅ Version Alignment:

  • Root package: 0.1.00.1.1
  • Text-generation package: 0.1.00.1.1
  • Both packages stay in sync ✅

❓ Semantic Versioning:

  • This is a patch version bump (0.1.00.1.1)
  • According to the PR description: "This version will include: Optional dependencies for text-generation and all extras"
  • However, PR Configure celeste-text-generation for PyPI publication #21 already added this functionality - so 0.1.1 appears to be publishing what was already in main
  • Verify: What actual changes are included in 0.1.1 that weren't in 0.1.0?

Action Items

Before Merging:

  1. Verify CI passes - All checks should be green
  2. ⚠️ Clarify what's included in 0.1.1 - The PR description mentions features added in PR Configure celeste-text-generation for PyPI publication #21, but if those were already merged, what's new in 0.1.1?
  3. ⚠️ Consider updating optional dependency constraints - Update pyproject.toml:36-37 to >=0.1.1 if needed
  4. Tag after merge - Remember to create the v0.1.1 tag after merging to trigger the publish workflow

After Merging:

  1. Create git tag: git tag v0.1.1 && git push origin v0.1.1
  2. Monitor the publish workflow to ensure successful deployment to PyPI
  3. Verify packages are available on PyPI:

Summary

Verdict: ✅ Approve with minor suggestions

This is a straightforward version bump PR. The changes are minimal and focused. The main suggestion is to clarify what's actually new in 0.1.1 and consider updating the optional dependency version constraints for consistency.

The PR follows the project's conventions, and the automated publish workflow provides good safety checks. Once merged and tagged, the packages should publish successfully to PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant