refactor: remove redundant StrEnum type annotations from ParameterMapper

[Kamilbenkirane]

Remove redundant : StrEnum type annotations from name attributes in ParameterMapper subclasses across text-generation providers. The base class ParameterMapper already declares name: StrEnum as an abstract attribute, making the explicit annotation in subclasses redundant.

This change follows DRY (Don't Repeat Yourself) principles and Python typing best practices. Type checkers can correctly infer the type from:

1. The base class declaration (ParameterMapper.name: StrEnum)
2. The enum value's type (Parameter.TEMPERATURE is already StrEnum)

Also removes unused from enum import StrEnum imports where no longer needed.

Affected providers:

• Anthropic
• Cohere
• Google
• Mistral
• OpenAI

[claude]

Code Review: PR #41 - Remove redundant StrEnum type annotations

Summary

This PR removes redundant : StrEnum type annotations from name attributes in ParameterMapper subclasses across all text-generation providers. The changes are well-justified and follow Python typing best practices.

✅ Code Quality and Best Practices

Strengths:

• DRY Principle: Correctly identifies and eliminates redundant type annotations. The base class ParameterMapper already declares name: StrEnum as an abstract attribute (src/celeste/parameters.py:18), making explicit annotations in subclasses unnecessary.
• Type Inference: Python's type checkers (mypy, pyright) can correctly infer the type from:
  1. The base class declaration
  2. The assigned enum value's type (e.g., TextGenerationParameter.THINKING_BUDGET is already a StrEnum)
• Consistency: Changes are applied uniformly across all 5 affected providers (Anthropic, Cohere, Google, Mistral, OpenAI)
• Clean Imports: Properly removes unused from enum import StrEnum imports where they're no longer needed

Best Practices Followed:

• The PR maintains the same runtime behavior while reducing code verbosity
• Aligns with PEP 484 typing conventions where redundant annotations should be avoided
• Follows the repository's strict mypy configuration (pyproject.toml:135-148)

🔍 Potential Issues

Minor Observations:

1. No Type Checker Validation in PR: While the changes should be type-safe, the PR description doesn't mention running mypy to verify. Given the strict mypy configuration in this project, I recommend running:

   mypy packages/text-generation/src/celeste_text_generation/providers/

2. Mistral Provider Import Cleanup: The Mistral file (mistral/parameters.py:1-2) removes the StrEnum import, but I notice it only has one mapper class. Verify that no other mappers in that file need the import.

🐛 Bugs

None identified. The changes are purely cosmetic refactoring with no functional impact.

⚡ Performance Considerations

No performance impact. Type annotations are stripped at runtime in Python, so this change has zero performance implications.

🔒 Security Concerns

None. This is a pure refactoring with no security implications.

🧪 Test Coverage

Observations:

• No test files found specifically for parameter mappers in packages/text-generation/tests/
• The core ParameterMapper protocol is tested in tests/unit_tests/test_parameters.py
• Integration tests exist but don't directly test mapper instantiation

Recommendations:

1. Consider adding tests for parameter mapper instantiation to ensure the name attribute is correctly set, e.g.:

   def test_mapper_name_attribute():
       mapper = ThinkingBudgetMapper()
       assert mapper.name == TextGenerationParameter.THINKING_BUDGET
       assert isinstance(mapper.name, StrEnum)

2. This would serve as a regression test and document the expected behavior.

However, given this is a refactoring PR with no functional changes, the lack of specific tests is acceptable if existing integration tests cover the mapper functionality.

📊 Overall Assessment

Verdict: ✅ APPROVE

This is a clean, well-reasoned refactoring that:

• Reduces code duplication
• Follows Python typing best practices
• Maintains type safety
• Has no functional changes or side effects

Suggested Actions Before Merge:

1. ✅ Run mypy on the modified files to confirm type checking passes
2. ✅ Run existing test suite to ensure no regressions
3. 💭 Consider adding basic mapper instantiation tests (optional, nice-to-have)

Great work on identifying and cleaning up this redundancy! 🎉