Skip to content

refactor: remove redundant StrEnum type annotations from ParameterMapper #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kamilbenkirane merged 1 commit into from
Nov 16, 2025
Merged

refactor: remove redundant StrEnum type annotations from ParameterMapper #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/text-generation/src/celeste_text_generation/providers/anthropic/parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"""Anthropic parameter mappers."""

import json
from enum import StrEnum
from typing import Any, get_args, get_origin

from pydantic import BaseModel, TypeAdapter
Expand All @@ -15,7 +14,7 @@
class ThinkingBudgetMapper(ParameterMapper):
"""Map thinking_budget parameter to Anthropic thinking.budget_tokens."""

name: StrEnum = TextGenerationParameter.THINKING_BUDGET
name = TextGenerationParameter.THINKING_BUDGET

def map(
self,
Expand Down Expand Up @@ -64,7 +63,7 @@ def map(
class OutputSchemaMapper(ParameterMapper):
"""Map output_schema parameter to Anthropic native structured outputs (output_format)."""

name: StrEnum = TextGenerationParameter.OUTPUT_SCHEMA
name = TextGenerationParameter.OUTPUT_SCHEMA

def map(
self,
Expand Down
9 changes: 4 additions & 5 deletions packages/text-generation/src/celeste_text_generation/providers/cohere/parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"""Cohere parameter mappers."""

import json
from enum import StrEnum
from typing import Any, get_args, get_origin

from pydantic import BaseModel, TypeAdapter
Expand All @@ -15,7 +14,7 @@
class TemperatureMapper(ParameterMapper):
"""Map temperature parameter to Cohere temperature field."""

name: StrEnum = Parameter.TEMPERATURE
name = Parameter.TEMPERATURE

def map(
self,
Expand All @@ -35,7 +34,7 @@ def map(
class MaxTokensMapper(ParameterMapper):
"""Map max_tokens parameter to Cohere max_tokens field."""

name: StrEnum = Parameter.MAX_TOKENS
name = Parameter.MAX_TOKENS

def map(
self,
Expand All @@ -55,7 +54,7 @@ def map(
class ThinkingBudgetMapper(ParameterMapper):
"""Map thinking_budget parameter to Cohere thinking parameter."""

name: StrEnum = TextGenerationParameter.THINKING_BUDGET
name = TextGenerationParameter.THINKING_BUDGET

def map(
self,
Expand Down Expand Up @@ -91,7 +90,7 @@ def map(
class OutputSchemaMapper(ParameterMapper):
"""Map output_schema parameter to Cohere response_format."""

name: StrEnum = TextGenerationParameter.OUTPUT_SCHEMA
name = TextGenerationParameter.OUTPUT_SCHEMA

def map(
self,
Expand Down
9 changes: 4 additions & 5 deletions packages/text-generation/src/celeste_text_generation/providers/google/parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"""Google parameter mappers."""

from enum import StrEnum
from typing import Any, get_args, get_origin

from pydantic import BaseModel, TypeAdapter
Expand All @@ -15,7 +14,7 @@
class TemperatureMapper(ParameterMapper):
"""Map temperature parameter to Google generationConfig."""

name: StrEnum = Parameter.TEMPERATURE
name = Parameter.TEMPERATURE

def map(
self,
Expand All @@ -35,7 +34,7 @@ def map(
class MaxTokensMapper(ParameterMapper):
"""Map max_tokens parameter to Google generationConfig.maxOutputTokens."""

name: StrEnum = Parameter.MAX_TOKENS
name = Parameter.MAX_TOKENS

def map(
self,
Expand All @@ -55,7 +54,7 @@ def map(
class ThinkingBudgetMapper(ParameterMapper):
"""Map thinking_budget parameter to Google generationConfig.thinkingConfig.thinkingBudget."""

name: StrEnum = TextGenerationParameter.THINKING_BUDGET
name = TextGenerationParameter.THINKING_BUDGET

def map(
self,
Expand All @@ -77,7 +76,7 @@ def map(
class OutputSchemaMapper(ParameterMapper):
"""Map output_schema parameter to Google generationConfig.responseSchema."""

name: StrEnum = TextGenerationParameter.OUTPUT_SCHEMA
name = TextGenerationParameter.OUTPUT_SCHEMA

def map(
self,
Expand Down
3 changes: 1 addition & 2 deletions packages/text-generation/src/celeste_text_generation/providers/mistral/parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"""Mistral parameter mappers."""

from enum import StrEnum
from typing import Any, get_args, get_origin

from pydantic import BaseModel, TypeAdapter
Expand Down Expand Up @@ -92,7 +91,7 @@ def map(
class OutputSchemaMapper(ParameterMapper):
"""Map output_schema parameter to Mistral response_format."""

name: StrEnum = TextGenerationParameter.OUTPUT_SCHEMA
name = TextGenerationParameter.OUTPUT_SCHEMA

def map(
self,
Expand Down
11 changes: 5 additions & 6 deletions packages/text-generation/src/celeste_text_generation/providers/openai/parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
"""OpenAI parameter mappers."""

import json
from enum import StrEnum
from typing import Any, get_args, get_origin

from pydantic import BaseModel, TypeAdapter
Expand All @@ -15,7 +14,7 @@
class OutputSchemaMapper(ParameterMapper):
"""Map output_schema parameter to OpenAI text.format."""

name: StrEnum = TextGenerationParameter.OUTPUT_SCHEMA
name = TextGenerationParameter.OUTPUT_SCHEMA

def map(
self,
Expand Down Expand Up @@ -146,7 +145,7 @@ def _get_schema_name(self, output_schema: Any) -> str: # noqa: ANN401
class TemperatureMapper(ParameterMapper):
"""Map temperature parameter to OpenAI temperature field."""

name: StrEnum = Parameter.TEMPERATURE
name = Parameter.TEMPERATURE

def map(
self,
Expand All @@ -166,7 +165,7 @@ def map(
class MaxTokensMapper(ParameterMapper):
"""Map max_tokens parameter to OpenAI max_output_tokens field."""

name: StrEnum = Parameter.MAX_TOKENS
name = Parameter.MAX_TOKENS

def map(
self,
Expand All @@ -186,7 +185,7 @@ def map(
class ThinkingBudgetMapper(ParameterMapper):
"""Map thinking_budget parameter to OpenAI reasoning.effort field."""

name: StrEnum = TextGenerationParameter.THINKING_BUDGET
name = TextGenerationParameter.THINKING_BUDGET

def map(
self,
Expand All @@ -206,7 +205,7 @@ def map(
class VerbosityMapper(ParameterMapper):
"""Map verbosity parameter to OpenAI text.verbosity field."""

name: StrEnum = TextGenerationParameter.VERBOSITY
name = TextGenerationParameter.VERBOSITY

def map(
self,
Expand Down
Loading