This repository was archived by the owner on Oct 11, 2022. It is now read-only.
2.4.3 #3233
Merged
2.4.3 #3233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and archive private channels
…tify-deleted-threads
fix upload images tooltip hover state
Refactoring
As @brianlovin noticed in #3199, the CD for the desktop app wasn't working because CircleCI only runs builds for commits that are associated with a PR. While we could set CircleCI to run builds for all branches, that's a very suboptimal solution as it would run a ton of unnecessary builds. I came to wondering, why does the CD for alpha work if it doesn't build branches? Hidden in the CircleCI docs I found this snippet: > Note: For your default branch, we will always build all commits. Which explains why alpha CD works, but production CD doesn't. This patch is a very simple solution to this problem: we run desktop CD on the alpha branch. That is fine because the desktop CD only creates a draft GitHub release and we have to manually publish that release for anybody to get the update, so it doesn't matter if we CD from alpha or production!
Instead of relying on a bunch of custom behavior this patch makes it so we use the standard `autoUpdater.checkForUpdatesAndNotify()` method and call it every 15 minutes. It also adds a menu item called "Check for updates" so users can manually check for updates.
Closes #3214
Dont show deleted threads in notifications dropdown
The desktop app requests the same paths as the browser would, which means previously it would also get the server-side rendered HTML. The problem is that the server-side rendered frontend doesn't know that it's being rendered for the desktop app, and thusly renders the standard frontend, which looks crappy in the desktop app. This patch disables server-side rendering enterily when a req from the desktop app comes in, which fixes that issue.
Fix focussing body when pressing enter in title in composer
Add hover profile to mentions
Update banning-users.md to include mutations to disable feature flags…
Fix desktop auto updating maybe
Add desktop deployment docs
Run desktop CD from the alpha branch
…top-app Don't server-side render for desktop app
…rum into show-login-on-desktop
Persist desktop app window state on reopen
Show login as first view on desktop startup
Bump desktop version
Generated by 🚫 dangerJS |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Deploy after merge (delete what needn't be deployed)