Skip to content

MADS-4855 ConnectedKeyboardAcc tracks incorrectly #3830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2025
Merged

MADS-4855 ConnectedKeyboardAcc tracks incorrectly #3830

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions lib/ios/reactnativeuilib/keyboardtrackingview/KeyboardTrackingViewTempManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,11 +173,14 @@ -(void)layoutSubviews
CGFloat bottomSafeArea = [self getBottomSafeArea];
CGFloat tabBarHeight = [self getTabBarHeight];
CGFloat yOffset = MIN(-bottomSafeArea, -_ObservingInputAccessoryViewTemp.keyboardHeight + tabBarHeight);

if (self.frame.origin.y != yOffset) {
[self removeObserver:self forKeyPath:@"frame"];
self.frame = CGRectMake(self.frame.origin.x,
yOffset,
self.frame.size.width,
self.frame.size.height);
[self addObserver:self forKeyPath:@"frame" options:NSKeyValueObservingOptionNew context:NULL];
}

[self updateBottomViewFrame];
Expand Down Expand Up @@ -431,7 +434,9 @@ - (NSArray*)getAllReactSubviewsForView:(UIView*)view

- (void)_updateScrollViewInsets
{
if(self.scrollViewToManage != nil)
// Because our view is now being transformed inside it's superview (from RN77 it inherited a RCTLegacyViewManagerInteropComponentView as superview) we no longer need the scrollview to also update because it's inside our view
return;
/*if(self.scrollViewToManage != nil)
{
UIEdgeInsets insets = self.scrollViewToManage.contentInset;
CGFloat bottomSafeArea = [self getBottomSafeArea];
Expand All @@ -441,6 +446,7 @@ - (void)_updateScrollViewInsets
CGPoint originalOffset = self.scrollViewToManage.contentOffset;

bottomInset += (_ObservingInputAccessoryViewTemp.keyboardHeight == 0 ? bottomSafeArea : 0);

if(self.scrollIsInverted)
{
insets.top = bottomInset;
Expand Down Expand Up @@ -477,7 +483,7 @@ - (void)_updateScrollViewInsets
insets.bottom = bottomInset;
}
self.scrollViewToManage.scrollIndicatorInsets = insets;
}
}*/
}

#pragma mark - bottom view
Expand Down Expand Up @@ -590,7 +596,11 @@ -(void)updateTransformAndInsets
}
[self updateBottomViewFrame];

self.transform = CGAffineTransformMakeTranslation(0, accessoryTranslation);
CGAffineTransform oldTransform = self.transform;
CGAffineTransform newTransform = CGAffineTransformMakeTranslation(0, accessoryTranslation);
if (oldTransform.tx != newTransform.tx || oldTransform.ty != newTransform.ty) {
self.transform = CGAffineTransformMakeTranslation(0, accessoryTranslation);
}

[self _updateScrollViewInsets];
}
Expand Down
Loading