VS2017DevEnvSearch does not find VS2017 if there are BuildTools installed.

[jbialobr]

Bugs

• Which version of WiX are you building with?

3.11.0.1528-rc2

• Which version of Visual Studio are you building with (if any)?

msbuild

• Which version of .NET are you building with?

v4.0.30319

• If the problem occurs when installing your packages built with WiX, what is the version of Windows the package is running on?

10

• Describe the problem and the steps to reproduce it.

I add VS2017DEVENV propertyref to enable installing VSIX extension for VS 2017
<PropertyRef Id="VS2017DEVENV" />

The installer does not find VS2017 if there are BuildTools installed.

AppSearch: Property: VS2017DEVENV, Signature: VS2017DevEnvSearch
MSI (c) (34:70) [10:08:43:256]: Note: 1: 1322 2:  
MSI (c) (34:70) [10:08:43:256]: Note: 1: 1322 2:  
MSI (c) (34:70) [10:08:43:256]: Note: 1: 1324 2: Common7\IDE 3: 1 
MSI (c) (34:70) [10:08:43:256]: Note: 1: 1324 2: Common7\IDE 3: 1 
AppSearch: Property: VS2017_IDE_DIR, Signature: VS2017EnvironmentDirectorySearch
MSI (c) (34:70) [10:08:43:258]: PROPERTY CHANGE: Adding VS2017_IDE_DIR property. Its value is 'C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\'.

Full log: BuildToolsInstalled.txt

The installer finds VS2017 if the BuildTools are not installed.

AppSearch: Property: VS2017DEVENV, Signature: VS2017DevEnvSearch
MSI (c) (98:F8) [09:50:37:400]: Note: 1: 1322 2:  
MSI (c) (98:F8) [09:50:37:400]: Note: 1: 1322 2:  
MSI (c) (98:F8) [09:50:37:400]: Note: 1: 1324 2: Common7\IDE 3: 1 
MSI (c) (98:F8) [09:50:37:400]: Note: 1: 1324 2: Common7\IDE 3: 1 
MSI (c) (98:F8) [09:50:37:400]: PROPERTY CHANGE: Adding VS2017DEVENV property. Its value is 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\devenv.exe'.
AppSearch: Property: VS2017_IDE_DIR, Signature: VS2017EnvironmentDirectorySearch
MSI (c) (98:F8) [09:50:37:401]: PROPERTY CHANGE: Adding VS2017_IDE_DIR property. Its value is 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\Common7\IDE\'.

Full log: NoBuildTools.txt

• Describe the behavior you expected and how it differed from the actual behavior.

The installer should find VS2017 regardless the BuildTools are installed.

[heaths]

Seems the recent support I added should've filtered to just the VS product IDs a la https://github.com/Microsoft/vswhere.

[heaths]

I'll take this one.

[RefaelP23]

Any updates on this?

[heaths]

This was checked in back on May 31st in commit 67b0389ad257ef32995d3909a069da39b501e45f. @barnson, could you close this issue? Seems it didn't auto-close.

[RefaelP23]

This still happens using Wix Toolset 3.11.0.1701:

With BuildTools:

AppSearch: 
MSI (c) (20:9C) [11:54:58:600]: Note: 1: 1325 2: Extensions 
MSI (c) (20:9C) [11:54:58:600]: Note: 1: 1324 2: Common7\IDE 3: 1 
MSI (c) (20:9C) [11:54:58:600]: Note: 1: 1324 2: Common7\IDE 3: 1 
MSI (c) (20:9C) [11:54:58:601]: PROPERTY CHANGE: Adding VS2017_EXTENSIONS_DIR property. Its value is 'C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\Extensions\'.
AppSearch: 
MSI (c) (20:9C) [11:54:58:601]: PROPERTY CHANGE: Adding VS2017_IDE_DIR property. Its value is 'C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\Common7\IDE\'.

And without BuildTools:

AppSearch: 
MSI (c) (98:64) [14:11:19:243]: Note: 1: 1325 2: Extensions 
MSI (c) (98:64) [14:11:19:243]: Note: 1: 1324 2: Common7\IDE 3: 1 
MSI (c) (98:64) [14:11:19:243]: Note: 1: 1324 2: Common7\IDE 3: 1 
MSI (c) (98:64) [14:11:19:243]: PROPERTY CHANGE: Adding VS2017_EXTENSIONS_DIR property. Its value is 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\Extensions\'.
AppSearch: 
MSI (c) (98:64) [14:11:19:243]: PROPERTY CHANGE: Adding VS2017_IDE_DIR property. Its value is 'C:\Program Files (x86)\Microsoft Visual Studio\2017\Professional\Common7\IDE\'.

[heaths]

Please run the following and paste the output (| clip will put it in the clipboard):

"C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -all -prerelease -format json | clip

If you don't have vswhere there, it means you have an old Visual Studio. You can download the EXE from https://github.com/Microsoft/vswhere/releases.

[RefaelP23]

[
  {
    "instanceId": "c7fd35d6",
    "installDate": "2017-10-17T13:53:29Z",
    "installationName": "VisualStudio/15.4.0+27004.2002",
    "installationPath": "D:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Professional",
    "installationVersion": "15.4.27004.2002",
    "productId": "Microsoft.VisualStudio.Product.Professional",
    "productPath": "D:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Professional\\Common7\\IDE\\devenv.exe",
    "isPrerelease": false,
    "displayName": "Visual Studio Professional 2017",
    "description": "Professional developer tools and services for small teams",
    "channelId": "VisualStudio.15.Release",
    "channelPath": "C:\\Users\\rafael\\AppData\\Local\\Microsoft\\VisualStudio\\Packages\\_Channels\\4CB340F5\\catalog.json",
    "channelUri": "https://aka.ms/vs/15/release/channel",
    "enginePath": "C:\\Program Files (x86)\\Microsoft Visual Studio\\Installer\\resources\\app\\ServiceHub\\Services\\Microsoft.VisualStudio.Setup.Service",
    "releaseNotes": "https://go.microsoft.com/fwlink/?LinkId=660692#15.4.0",
    "thirdPartyNotices": "https://go.microsoft.com/fwlink/?LinkId=660708",
    "catalog": {
      "buildBranch": "d15svc",
      "buildVersion": "15.4.27004.2002",
      "id": "VisualStudio/15.4.0+27004.2002",
      "localBuild": "build-lab",
      "manifestName": "VisualStudio",
      "manifestType": "installer",
      "productDisplayVersion": "15.4.0",
      "productLine": "Dev15",
      "productLineVersion": "2017",
      "productMilestone": "RTW",
      "productMilestoneIsPreRelease": "False",
      "productName": "Visual Studio",
      "productPatchVersion": "0",
      "productPreReleaseMilestoneSuffix": "6.0",
      "productRelease": "RTW",
      "productSemanticVersion": "15.4.0+27004.2002"
    },
    "properties": {
      "campaignId": "168654337.1504175679",
      "channelManifestId": "VisualStudio.15.Release/15.4.0+27004.2002",
      "defaultProgram": "VisualStudio.c7fd35d6",
      "nickname": "",
      "setupEngineFilePath": "C:\\Program Files (x86)\\Microsoft Visual Studio\\Installer\\vs_installershell.exe"
    }
  }
]

This is the same output when running the command with and w/o BuildTools installed.
Update: This problem also happened with SQL installed (not on my machine):

AppSearch: Property: VS2017_EXTENSIONS_DIR, Signature: VS2017ExtensionsDirectorySearch
MSI (c) (5C:90) [15:32:41:902]: Note: 1: 1325 2: Extensions 
MSI (c) (5C:90) [15:32:41:902]: Note: 1: 1324 2: Common7\IDE 3: 1 
MSI (c) (5C:90) [15:32:41:902]: Note: 1: 1324 2: Common7\IDE 3: 1 
MSI (c) (5C:90) [15:32:41:903]: PROPERTY CHANGE: Adding VS2017_EXTENSIONS_DIR property. Its value is 'C:\Program Files (x86)\Microsoft Visual Studio\2017\SQL\Common7\IDE\Extensions\'.

It works fine when only VS is installed.

[heaths]

I don't see Build Tools registered at all, meaning it shouldn't be found. Just run vswhere with no parameters and copy/paste the version header.

[RefaelP23]

Visual Studio Locator version 2.2.11+gf1a9c6c78d [query version 1.14.187.27757]
Copyright (C) Microsoft Corporation. All rights reserved.

Could there be something missing in the installer that targets BuildTools/SQL when they are installed?