Changed the includes of 404 pages by a regexp test #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emes that implements onCreatePage on gatsby-node.js
Merge with next
wiziple
requested changes
Jul 30, 2019
Owner
wiziple
left a comment
wiziple
left a comment
There was a problem hiding this comment.
Please change back unrelated code changes.
Contributor
Author
|
Done! Sorry about that 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the includes check for creating matchPath of 404 pages by a regexp.
The current includes was checking /404/, but since I am using the gatsby-plugin-remove-trailing-slashes, my matching string should be just /404, so I think it would be better to check both, and so is why I used a regexp which I think it does the job very well. It checks for / then 404 then an optional / and then it should be the end of the string (/404/?$)