Skip to content

Changed the includes of 404 pages by a regexp test #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 9, 2019
Merged

Changed the includes of 404 pages by a regexp test #59

Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
57de1ab
Fixed issue#18 and other potentially issues with any other plugins/th…
talensjr Jul 23, 2019
98907b4
Added wrap-page fix
talensjr Jul 24, 2019
02dda9b
Fixed conflict
talensjr Jul 24, 2019
83f0325
Merge pull request #1 from talensjr/merge-with-next
talensjr Jul 24, 2019
7a9faac
Changed package name
talensjr Jul 24, 2019
b374ff1
Changed package version
talensjr Jul 24, 2019
a5e5808
Package.json changes
talensjr Jul 24, 2019
f586d2d
Changed an includes by a regexp test for a 404 page, so now it checks…
talensjr Jul 26, 2019
22980e1
Fixed conflicts
talensjr Jul 26, 2019
9f47dec
Added missing $ to the regexp
talensjr Jul 26, 2019
786852d
Fixed code unrelated to the change
talensjr Jul 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/gatsby-node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ exports.onCreatePage = async ({ page, actions }, pluginOptions) => {

languages.forEach(language => {
const localePage = generatePage(true, language)
if (localePage.path.includes(`/404/`)) {
const regexp = new RegExp("/404/?$")
if (regexp.test(localePage.path)) {
localePage.matchPath = `/${language}/*`
}
createPage(localePage)
Expand Down