Skip to content

feat: ship Windows AMD64 binary wheels - #63

Merged
wkentaro merged 1 commit into
mainfrom
feat/windows-wheels
Jun 20, 2026
Merged

feat: ship Windows AMD64 binary wheels#63
wkentaro merged 1 commit into
mainfrom
feat/windows-wheels

Conversation

@wkentaro

@wkentaro wkentaro commented Jun 20, 2026

Copy link
Copy Markdown
Owner

Adds a windows-latest / AMD64 runner to the cibuildwheel matrix in wheels.yml so pip install octomap-python pulls a prebuilt wheel on Windows instead of requiring MSVC build tools.

The existing build = "cp39-* … cp314-*" pattern already matches *-win_amd64, so only the runner was needed. The OctoMap FetchContent sources already compile under MSVC (the sdist from source (windows) job has been green), so the wheel build reuses that path and runs the test suite via cibuildwheel's test-command. That sdist job stays as a guard for the remaining from-source cases (win_arm64, sdist fallback); its now-stale "ships no wheel" comment is updated.

Closes #62.

Test plan

  • This PR's wheels.yml run produces octomap_python-*-cp3XX-win_amd64.whl (real verification, since MSVC/cibuildwheel only runs in CI)

Add a windows-latest/AMD64 runner to the cibuildwheel matrix so
pip install octomap-python pulls a prebuilt wheel on Windows instead of
requiring MSVC build tools. The existing build = "cp39-* ... cp314-*"
pattern already matches *-win_amd64, so only the runner is needed.

The sdist-from-source Windows job stays as a guard for the remaining
from-source path (win_arm64, sdist fallback).

Closes #62
@wkentaro wkentaro self-assigned this Jun 20, 2026
@wkentaro

Copy link
Copy Markdown
Owner Author

This was generated by AI during PR processing.

Verdict: recommend-merge

Adds a windows-latest / AMD64 runner to the cibuildwheel matrix so pip install octomap-python pulls a prebuilt wheel on Windows instead of requiring MSVC build tools.

Checks:

  • CI green, including the new Wheels (windows-latest AMD64) build and the unchanged sdist from source (windows) guard.
  • No rebase needed: branch is even with main (0 commits behind), merge state CLEAN.
  • Publish path verified: publish.yml downloads all artifacts with merge-multiple: true and ships everything in dist/, so the new wheels-windows-latest-AMD64 wheel flows to PyPI automatically with no change to publish.yml.
  • Code review (medium, report-only): no findings. Single logical commit, accurate comment for the remaining from-source path (win_arm64 / sdist fallback).

Ready for maintainer review and merge.

@wkentaro wkentaro added the recommend-merge pr: Agent finalized and endorses it: review and merge label Jun 20, 2026
@wkentaro wkentaro added this to the v1.10.0.0 milestone Jun 20, 2026
@wkentaro
wkentaro merged commit e537f9d into main Jun 20, 2026
8 checks passed
@wkentaro
wkentaro deleted the feat/windows-wheels branch June 20, 2026 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

recommend-merge pr: Agent finalized and endorses it: review and merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ship Windows binary wheels

1 participant