feat: ship Windows AMD64 binary wheels - #63
Merged
Merged
Conversation
Add a windows-latest/AMD64 runner to the cibuildwheel matrix so pip install octomap-python pulls a prebuilt wheel on Windows instead of requiring MSVC build tools. The existing build = "cp39-* ... cp314-*" pattern already matches *-win_amd64, so only the runner is needed. The sdist-from-source Windows job stays as a guard for the remaining from-source path (win_arm64, sdist fallback). Closes #62
Owner
Author
Verdict: Adds a Checks:
Ready for maintainer review and merge. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
windows-latest/AMD64runner to the cibuildwheel matrix inwheels.ymlsopip install octomap-pythonpulls a prebuilt wheel on Windows instead of requiring MSVC build tools.The existing
build = "cp39-* … cp314-*"pattern already matches*-win_amd64, so only the runner was needed. The OctoMap FetchContent sources already compile under MSVC (thesdist from source (windows)job has been green), so the wheel build reuses that path and runs the test suite via cibuildwheel'stest-command. That sdist job stays as a guard for the remaining from-source cases (win_arm64, sdist fallback); its now-stale "ships no wheel" comment is updated.Closes #62.
Test plan
wheels.ymlrun producesoctomap_python-*-cp3XX-win_amd64.whl(real verification, since MSVC/cibuildwheel only runs in CI)