Allow product information to be specified at build time

[Moustachauve]

This allow people who make custom builds of WLED (Ex: QuinLED) to specify the details about the product at build time rather than having it hardcoded. The default values of WLED are unchanged.

This is similar to #3407 and has a similar end goal.

[blazoncek]

IMO the goal is OK but the implementation is not. Changing existing behaviour will break functionality at some point.
I think a better approach would be a new API for this specific purpose.

[Moustachauve]

IMO the goal is OK but the implementation is not. Changing existing behaviour will break functionality at some point. I think a better approach would be a new API for this specific purpose.

The existing behavior is not changed at all in my opinion. The API result will be exactly the same as before.
3rd party devices could already change that value at compile time if they wanted (that's why the value is in the API afterall)

[blazoncek]

Unfortunately I cannot comment the use in JSON API as I do not know what was original purpose. I also do not know which 3rd party systems use these fields for their purpose (HomeAssistant and possibly others?) in determining connected systems. Please research which 3rd party systems use "mf" and "mdl" JSON API fields. Perhaps @Aircoookie can shed some more light when he returns.

Still, I cannot approve the change in MQTT as I know the fields are needed for correct classification of HomeAssistant devices detected. This will certainly break existing configurations.

[Moustachauve]

I would argue that for most people editing these fields, making sure these are not detected as WLED would be a benefit and not a bug.

[Moustachauve]

I also do not know which 3rd party systems use these fields for their purpose (HomeAssistant and possibly others?) in determining connected systems. Please research which 3rd party systems use "mf" and "mdl" JSON API fields.

mf and mdl are only in usermods. No third party rely on it for 99% of the cases. These values are already modifiable. Why prevent people from modifying them if they want to? This does not affect default builds of WLED in any way. I can add more documentation to say to be careful when modifying these values but that's not something default WLED ever has to worry about.

Still, I cannot approve the change in MQTT as I know the fields are needed for correct classification of HomeAssistant devices detected. This will certainly break existing configurations.

I just checked both in the code of Home Assistant and by testing with my own instance of HA and I am happy to report to you that Home Assistant does not use MQTT at all for WLED and also the device has full functionality.

[blazoncek]

👍