Update GitHub Actions workflow - #3718
Merged
Merged
Conversation
This also adds a WLED_RELEASE_NAME for esp32s3dev_8MB_PSRAM_opi
Contributor
Contributor
Author
|
@dosipod Thanks for the hint on ESP02! I didn't know we needed bin.gz files for ESP02. So I will change this and add bin.gz files for ESP02 to the artifacts as well. |
Contributor
|
@WoodyLetsCode No gz is only needed for esp02 ( 2MB ) when using OTA , ESP01 1MB does not work with OTA so gz is useless . The normal esp8266 4MB OTA will work without gz |
Contributor
Author
|
So now for ESP02 we have two files in the artifact:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This updates the GitHub Actions workflow and all the GitHub Actions used.
This was necessary because the old workflow was throwing warnings:

I also optimized the caching for PlatformIO. Now building is much faster:
I also removed some unnecessary code, like caching the python setup with the
actions/cacheaction. Here we can just use the built-in cache function of theactions/setup-pythonaction.The
GITHUB_TOKENis also not needed. You would only need aGITHUB_TOKENif you want to create releases in other repositories.In the previous version, we had
build_output/firmware/*.bin.gzandbuild_output/firmware/*.binfiles in the artifacts. I see no reason to do this. It just combines the disadvantages of uncompressed files and the disadvantages of compressed files.When creating a new tag, I also see no reason to have the files from
build_output/firmwareandbuild_output/release. They are the same files, just with different filenames. So now I have changed it so that we always use the release files for artifacts.Creating a draft release with built files whenever a new tag is created remains the same.