Code Review Changelog

Code Review Changelog

Cycle: Jul 16–17, 2026 · Baseline d974cab → Head 70463b1 · Branch main

What the .NET 10 upgrade review turned up — and the work it set in motion.

Review verdict — the upgrade diff was clean

A high-effort review of the merged .NET 10 / VS 2026 / SQL Server 2025 upgrade found no correctness bugs. The two non-mechanical migrations were verified at runtime:

• OpenApi v2 — OpenApiSecuritySchemeReference / AddSecurityRequirement(document => …)
• MSTest 4.x async — Execute/Invoke → ExecuteAsync/InvokeAsync

The only real signal was environmental: 50 tests failed because macOS can't host SQL Server LocalDB — not a regression. That thread drove the changes below.

At a glance

Metric	Value
Test suite	4 → 54 passing on macOS / Linux
Net change	+719 / −76 across 17 files
PRs merged	3 (issues #3 · #5 closed)

Changes — newest first

PR #7 — Repo hygiene: ignores & task tidy · chore/docs · 70463b1

Added a .DS_Store ignore rule, tidied completed items in TASKS.md, and committed the three framework-standard front-end .gitignore files (Angular / React / Vue) that were scaffolded but never tracked — closing a gap where a npm run build could leak dist/ and cache output into commits.

.gitignore · TASKS.md · DemoAngular/.gitignore · DemoReact/.gitignore · DemoVue/.gitignore

PR #6 — Run the test suite locally on EF Core InMemory · test · Closes #5 · 8b158f2

A config-driven provider switch (Demo:UseInMemoryDatabase) replaces SQL Server LocalDB with the EF Core InMemory provider, backed by a shared database root, seeded fixtures matching the Demo:Test*Ids, and a custom DemoWebApiFactory host — so the full suite runs with no SQL Server. A path back to real SQL Server is kept for Windows CI.

Result: 4 → 54 passing, stable across repeated runs on macOS.

TestDatabase.cs · DemoWebApiFactory.cs · DemoSqlContext.InMemory.cs · TestBase.cs · + WebApiTests

PR #4 — MSTEST0057: caller-info on the DI attribute · test · Closes #3 · f37bc78

Added a [CallerFilePath]/[CallerLineNumber] constructor to the custom TestMethodDependencyInjection attribute, forwarding to the base TestMethodAttribute ctor. Resolves the MSTest 4.x analyzer warning so the runner reports accurate source locations for the many tests that use it.

TestMethodDependencyInjection.cs

---

The reviewed upgrade was sound as-is; the value delivered was making the test suite cross-platform runnable and tightening the hygiene around it.

Interactive version: see the shared Artifact changelog.