Release 2.0.2: resolve remaining code-review issues - #32
Merged
Conversation
- Use chpasswd in setPassword for reliable non-interactive updates - Accept Linux login names up to 32 characters - Prevent duplicate SSH keys in addSSHtoUser - Route removeUser/addUserToGroup through spawnWrapper - Add Linux platform guard to lib/promise.js - Update README and docs website for new behavior - Bump version to 2.0.2 Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the outstanding items from
docs/issues.mdand the rootissue.mdreport, plus a few related cleanups.Changes
setPasswordnow useschpasswdinstead of writing topasswd's stdin.validateUsernamenow accepts Linux login names up to 32 characters.addSSHtoUserchecksauthorized_keysand skips appending an already-present key.removeUserandaddUserToGroupnow route throughspawnWrapper, so they share the same error contract and optional timeout support.lib/promise.jsnow enforces the Linux platform check when required directly.addUserstring shortcut,chpasswdrequirement, and duplicate-key behavior; aligned navigation across all Pages HTML files and updated the copyright year.addUserstring shortcut, and duplicate-key prevention.2.0.2and updated the changelog.Verification
npm testpasses (root-only tests are skipped as expected when not running as root).npm run lintpasses.🤖 Generated with Claude Code