This repository was archived by the owner on Mar 25, 2021. It is now read-only.
Load more results for PropertyLookup on scroll#93
Merged
bereket-WMDE merged 1 commit intoDec 14, 2020
Conversation
Ladsgroup
suggested changes
Dec 4, 2020
| :search-input.sync="search" | ||
| :placeholder="$i18n('query-builder-property-lookup-placeholder')" | ||
| :label="$i18n('query-builder-property-lookup-label')" | ||
| v-on:scroll="handelScroll" |
| @@ -66,6 +66,7 @@ describe( 'FetchSearchEntityRepository', () => { | |||
| origin: '*', | |||
| limit, | |||
| offset, | |||
Contributor
There was a problem hiding this comment.
The offset here is not needed at all: https://www.wikidata.org/w/api.php?action=help&modules=wbsearchentities
| @@ -28,6 +28,7 @@ export default class FetchSearchEntityRepository implements SearchEntityReposito | |||
| } | |||
| if ( offset ) { | |||
| params.offset = `${offset}`; | |||
bereket-WMDE
force-pushed
the
Load_more_results_for_PropertyLookup_on_scroll
branch
from
90f7672 to
ab131c1
Compare
Bug: T268508
bereket-WMDE
force-pushed
the
Load_more_results_for_PropertyLookup_on_scroll
branch
from
ab131c1 to
94a8504
Compare
bereket-WMDE
deleted the
Load_more_results_for_PropertyLookup_on_scroll
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: T268508