This repository was archived by the owner on May 1, 2025. It is now read-only.
eslint: Disable duplicate eslint rule for indentation#345
Merged
Conversation
micgro42
reviewed
Jan 7, 2021
| '@typescript-eslint/no-var-requires': 'off', | ||
|
|
||
| // duplicate with eslint's indent | ||
| '@typescript-eslint/indent': 'off', |
Collaborator
There was a problem hiding this comment.
Wait, but shouldn't we turn off indent instead? At least that is how I understand typescript-eslint/indent.md. Or are we affected by the issue mentioned there?
Contributor
Author
There was a problem hiding this comment.
I overlooked this, you're right.
tzhelyazkova
force-pushed
the
disable_duplicate_no_indent
branch
from
35c9073 to
d3cb951
Compare
micgro42
approved these changes
Jan 7, 2021
Collaborator
micgro42
left a comment
micgro42
left a comment
There was a problem hiding this comment.
The visual change is probably just a missing rebase or something like that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The eslint rules
@typescript-eslint/indentandindentare the same.This commit turns off
@typescript-eslint/indent.