This repository was archived by the owner on May 1, 2025. It is now read-only.
Conversation
This removes the label style and adds a token to reduce the line-height of "body" so this can be used as the default style by all components.
sai-san
commented
Sep 7, 2021
Wondering whether those height tokens should be renamed altogether
sai-san
commented
Sep 28, 2021
This PR creates a Story for the Table component added in this commit. * Add Table Story * Add min width for normalized column header Co-authored-by: Itamar Givon <itamar.givon.dev@gmail.com> Co-authored-by: Silvan Heintze <59574251+Silvan-WMDE@users.noreply.github.com> Co-authored-by: SaiSan <sarai.sanchez@wikimedia.de> Bug: T291077
itamargiv
approved these changes
Sep 28, 2021
Member
itamargiv
left a comment
itamargiv
left a comment
There was a problem hiding this comment.
AFAICT all the tokens look great, thank you!
jakobw
pushed a commit
that referenced
this pull request
Nov 4, 2021
* Add body-component line-height This removes the label style and adds a token to reduce the line-height of "body" so this can be used as the default style by all components. * Update ToggleButton.json * 💥 Breaking changes 💥 * Add table component tokens * Update Table.json * Correct line-height * Align small line-height with design guidelines * Update Table.json * Update Table.json Wondering whether those height tokens should be renamed altogether * Update tokens/properties/components/Table.json * Add Table Story (#489) This PR creates a Story for the Table component added in this commit. * Add Table Story * Add min width for normalized column header Co-authored-by: Itamar Givon <itamar.givon.dev@gmail.com> Co-authored-by: Silvan Heintze <59574251+Silvan-WMDE@users.noreply.github.com> Co-authored-by: SaiSan <sarai.sanchez@wikimedia.de> Bug: T291077 Co-authored-by: Guergana Tzatchkova <guergana.tzatchkova@wikimedia.de> Co-authored-by: Itamar Givon <itamar.givon.dev@gmail.com> Co-authored-by: Silvan Heintze <59574251+Silvan-WMDE@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes available a first draft of the tokens needed to style the simple table component.
Issue: T289053