This repository was archived by the owner on May 1, 2025. It is now read-only.
Add Table Story#489
Merged
itamargiv merged 14 commits intoadd-table-tokensfrom Sep 28, 2021
Merged
Conversation
sai-san
reviewed
Sep 28, 2021
sai-san
reviewed
Sep 28, 2021
sai-san
reviewed
Sep 28, 2021
itamargiv
reviewed
Sep 28, 2021
| <td data-header="Vegetable"> | ||
| {{cell.col1}} | ||
| </td> | ||
| <td data-header="Column 2">{{cell.col2}}</td> |
Member
There was a problem hiding this comment.
The value of data header should be displayed, this is how the table works...
itamargiv
force-pushed
the
table-story
branch
from
de84b4d to
0148576
Compare
itamargiv
force-pushed
the
table-story
branch
from
0148576 to
67e0c80
Compare
itamargiv
reviewed
Sep 28, 2021
Silvan-WMDE
reviewed
Sep 28, 2021
Member
Silvan-WMDE
left a comment
Silvan-WMDE
left a comment
There was a problem hiding this comment.
Looks good to me and works great on chromatic
Comment on lines
+106
to
+108
| // Ensure headers stay exactly 40% | ||
| // even if values are wider than 60% | ||
| min-width: 40%; |
Silvan-WMDE
approved these changes
Sep 28, 2021
In tables, numbers should be right-eligned in order to make them easy to compare. This is something that implenters could achieve in context. In order to avoid having to make any adjustments to the story, we could use a different example that doesn't include numbers, so we don't display a suboptimal design decision.
sai-san
reviewed
Sep 28, 2021
sai-san
reviewed
Sep 28, 2021
sai-san
reviewed
Sep 28, 2021
Member
|
What an all encompassing collaboration! Well done everyone 👏 👏 |
sai-san
added a commit
that referenced
this pull request
Sep 28, 2021
* Add body-component line-height This removes the label style and adds a token to reduce the line-height of "body" so this can be used as the default style by all components. * Update ToggleButton.json * 💥 Breaking changes 💥 * Add table component tokens * Update Table.json * Correct line-height * Align small line-height with design guidelines * Update Table.json * Update Table.json Wondering whether those height tokens should be renamed altogether * Update tokens/properties/components/Table.json * Add Table Story (#489) This PR creates a Story for the Table component added in this commit. * Add Table Story * Add min width for normalized column header Co-authored-by: Itamar Givon <itamar.givon.dev@gmail.com> Co-authored-by: Silvan Heintze <59574251+Silvan-WMDE@users.noreply.github.com> Co-authored-by: SaiSan <sarai.sanchez@wikimedia.de> Bug: T291077 Co-authored-by: Guergana Tzatchkova <guergana.tzatchkova@wikimedia.de> Co-authored-by: Itamar Givon <itamar.givon.dev@gmail.com> Co-authored-by: Silvan Heintze <59574251+Silvan-WMDE@users.noreply.github.com>
jakobw
pushed a commit
that referenced
this pull request
Nov 4, 2021
* Add body-component line-height This removes the label style and adds a token to reduce the line-height of "body" so this can be used as the default style by all components. * Update ToggleButton.json * 💥 Breaking changes 💥 * Add table component tokens * Update Table.json * Correct line-height * Align small line-height with design guidelines * Update Table.json * Update Table.json Wondering whether those height tokens should be renamed altogether * Update tokens/properties/components/Table.json * Add Table Story (#489) This PR creates a Story for the Table component added in this commit. * Add Table Story * Add min width for normalized column header Co-authored-by: Itamar Givon <itamar.givon.dev@gmail.com> Co-authored-by: Silvan Heintze <59574251+Silvan-WMDE@users.noreply.github.com> Co-authored-by: SaiSan <sarai.sanchez@wikimedia.de> Bug: T291077 Co-authored-by: Guergana Tzatchkova <guergana.tzatchkova@wikimedia.de> Co-authored-by: Itamar Givon <itamar.givon.dev@gmail.com> Co-authored-by: Silvan Heintze <59574251+Silvan-WMDE@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates a Story for the Table component added in this commit.
Bug: T291077