Skip to content

Un-ignore .github/ in release tarball to unblock Scorecard workflow checks#48

Merged
wnstfy merged 1 commit into
mainfrom
chore/unignore-github-tarball
May 22, 2026
Merged

Un-ignore .github/ in release tarball to unblock Scorecard workflow checks#48
wnstfy merged 1 commit into
mainfrom
chore/unignore-github-tarball

Conversation

@wnstfy

@wnstfy wnstfy commented May 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Same root cause as PR #45 (renovate.json un-ignore): Scorecard scans the tarball, which honors .gitattributes export-ignore. Excluding .github/ made four checks fail to find anything to evaluate.

What this unblocks

Check Was Will be Why
Dangerous-Workflow (critical) ? (-1) 10 Workflows already follow safe patterns (no pull_request_target + checkout, env-hoisted user input)
Pinned-Dependencies (medium) ? (-1) 10 All actions pinned by SHA; Renovate enforces via helpers:pinGitHubActionDigests
Token-Permissions (high) ? (-1) ~8-10 Every workflow has least-privilege permissions: block
Packaging (medium) ? (-1) 5-10 release.yml uses gh release create — heuristic may or may not recognize it

Projected overall: 7.4 → ~8.7-9.0 after Tuesday's scan (Dangerous-Workflow is critical weight).

Test plan

  • .gitattributes change validates: one line removed, replaced with explanatory comment block
  • CI green (scan, misconfig, lint)
  • Next Scorecard scan (Tuesday 07:20 UTC, or sooner via branch_protection_rule/push:main triggers) shows the 4 checks reporting actual scores
  • Verify release tarball size: ~30-40 KB heavier than before

…hecks

Same root cause as the renovate.json export-ignore restored in PR #45:
OpenSSF Scorecard scans the repo via GitHub's /tarball/ endpoint, which
honors .gitattributes export-ignore. Excluding .github/ caused four
checks (Dangerous-Workflow, Pinned-Dependencies, Token-Permissions,
Packaging) to report "no workflows found" and skip with score -1 —
rendered as "?" in the scorecard.dev viewer.

Restoring .github/ to the tarball adds ~30-40 KB but unblocks Scorecard's
validation of the workflow hardening that's already in place:
SHA-pinned actions, least-privilege permissions blocks, no
pull_request_target with checkout, env-hoisted user input.

Projected score impact: 7.4 → ~8.7-9.0 after next scan, depending on
how Packaging's heuristic evaluates our `gh release create`-based
release workflow.

Tracked upstream as ossf/scorecard#5069.
@wnstfy
wnstfy enabled auto-merge (squash) May 22, 2026 18:07
@wnstfy
wnstfy merged commit 3ece0d5 into main May 22, 2026
3 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Trivy misconfiguration findings (HIGH + CRITICAL)

✅ No HIGH or CRITICAL misconfigurations detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant