Cleaner config with config.h, CI build, fix string bug#11
Merged
Conversation
Owner
wojas
commented
Oct 31, 2025
wojas
commented
- Add a config.h for all the configuration defines
- Fix a bug with incorrect string types (String vs std::string)
- Also build firmware in CI to catch errors
- Add OTA password to secrets
Collapse CI into a single job that runs both the native unit test suite and the ESP32 firmware build so we catch type regressions early without extra setup overhead.
Guard the secrets include with __has_include so CI builds can fall back to the example header when a private secrets.h is absent.
Copy secrets.example.h to secrets.h during CI runs so clean builds have the header, and keep firmware sources including secrets.h directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.