Skip to content

ACP: Missing SessionUpdate notifications (user_message_chunk + tool_call_start/end) #196

Description

@Leoyzen

Missing Feature: ACP SessionUpdate notifications not emitted

Found by: test_acp_session_updates.py (2 xfail)

Missing notifications:

  1. user_message_chunk — AgentPool ACP server does not emit user_message_chunk SessionUpdate notification when user sends a message
  2. tool_call_start / tool_call_end — AgentPool does not emit tool_call_start/end SessionUpdate notifications when a tool is invoked

Location: src/agentpool_server/acp_server/event_converter.py — SessionUpdate conversion logic

Impact: ACP clients (e.g., Zed) cannot see user message echo or tool call progress via SessionUpdate notifications.

Tests:

  • tests/e2e/test_acp_session_updates.py (user_message_chunk)
  • tests/e2e/test_acp_session_updates.py::test_tool_call_start_end_notifications

Severity: Low-Medium — these are optional ACP v1 notifications; 9 other SessionUpdate variants ARE emitted correctly

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions