[ADC-753] Enforce model-declared recovery admissibility - #662
Merged
wolf75222 merged 6 commits intoAug 1, 2026
Merged
Conversation
wolf75222
merged commit Aug 1, 2026
2d21b16
into
codex/p2-consolidation-history-20260730
21 of 22 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
HasRecoveryAdmissibilitymodel contract and forwards it throughCompositeModelprepare_model_variable_recoveryinstall that declared predicate in the executable recovery planModel.recovery_admissibility(rho=rho > 0, p=p > 0)Why
The existing ADC-753 foundation rejected non-finite candidates transactionally, but a finite primitive state could still violate model physics. The Python model had no route to put density, pressure, realizability, or similar constraints into the native prepared recovery chain. This slice closes that concrete authoring-to-execution gap without introducing callbacks or a second recovery engine.
Functional proof in this slice
Modelis the authoring authoritykInadmissibleCandidate, retains the failing primitive component, and cannot be publishedValidation performed
Source-only validation, intentionally without a native build:
git diff --checkpassedThe native
test_variable_recovery_chaincase was added but was not compiled or executed in this lot per the no-build instruction.Deliberately not claimed
This does not close ADC-753. It does not add iterative recovery methods, declared repair publication, persistent patch/device workspaces, warm-start persistence across regrid/migration/restart, species-qualified multi-state policies, GPU/MPI evidence, benchmarks, or full consumer/no-bypass proof.
Stacked on the P2 consolidation branch because the transactional recovery chain from PR #609 is not yet on master.
Linear: ADC-753