Some minor fixes to build WolfSSL FIPS bundle#102
Closed
jviguera wants to merge 2 commits intowolfSSL:masterfrom
Closed
Some minor fixes to build WolfSSL FIPS bundle#102jviguera wants to merge 2 commits intowolfSSL:masterfrom
jviguera wants to merge 2 commits intowolfSSL:masterfrom
Conversation
The do_unpack task failed because FILE_DIRNAME is expanded at task execution time to a directory that does not contain the wolfssl FIPS package. To solve this, use the COMMERCIAL_CONFIG_DIR variable, which captures the correct path through immediate expansion at parsing time. Signed-off-by: Javier Viguera <javier.viguera@digi.com>
Switched variable assignments to use "?=" to allow setting them from the project's configuration file (local.conf) without modifying the bbappend. This allows for a clean update of meta-wolfssl, as the repository no longer needs to retain local changes. Signed-off-by: Javier Viguera <javier.viguera@digi.com>
|
Can one of the admins verify this patch? |
Member
|
Hi @jviguera , thank you for these suggestions! We are going to put up a PR with patches similar to this for the other commercial bundles as well. We'll reference those shortly and close this PR. Thanks, David Garske, wolfSSL |
Contributor
|
Hello @jviguera I have put up PR #103 This pulls in your recommendations, but also allows other commercial recipes to be updated in a similar fashion. Do note that instead of using 'WOLF_SRC*' variable. I have changed it to use 'WOLFSSL_SRC*', 'WOLFSSH_SRC*', ect variables for the recipes. I will be closing this PR, but please let us know if there are any issues you spot in PR #103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of commits that allow building the FIPS bundle without modifying meta-wolfssl and fixing the do_unpack function to be able to find the compressed package.