Updated wolfssl-python-3.8.14.patch cipher suite size can be 32 or 48#211
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Nov 22, 2024
Merged
Updated wolfssl-python-3.8.14.patch cipher suite size can be 32 or 48#211JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom
Conversation
… now and unified patch
dgarske
approved these changes
Nov 21, 2024
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
Thanks for updating this patch. Let's merge it in and make sure tests continue to pass. It builds fine and tests look good.
dgarske
assigned
dgarske,
wolfSSL-Bot and
JacobBarthelmeh and unassigned
dgarske and
aidangarske
JacobBarthelmeh
approved these changes
Nov 22, 2024
| + # reason may occasionally be None here | ||
| + if cm.exception.reason is not None: | ||
| + self.assertEqual(cm.exception.reason, 'fatal error') | ||
| + self.assertEqual(cm.exception.reason, 'ALERT_FATAL_ERROR') |
Contributor
There was a problem hiding this comment.
This change might lead to flaky test results. The change is okay as is, mainly making the note to help remind myself to keep an eye on retry rates.
Member
There was a problem hiding this comment.
@JacobBarthelmeh this change was already here. It was previously appended to the end of the original patch. It took Aidan and I a while to figure that out. This is the state of the current patch.
Thank you for merging. Let's see if the Python tests continue passing and I'll retry #7771 and see if it passes now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated wolfssl-python-3.8.14.patch cipher suite size can be 32 or 48 now and unified patch fix for the issue in initsuites and pr# 7771