20241121-fixes#8211
Merged
JacobBarthelmeh merged 1 commit intowolfSSL:masterfrom Nov 22, 2024
Merged
Conversation
…E ("wolfCrypt generic failure") with value -1, for traceable error return of -1 in wolfCrypt.
configure.ac: add OPENSSL_EXTRA to --enable-wolfsentry.
linuxkm/linuxkm_wc_port.h, linuxkm/module_hooks.c, wolfssl/ssl.h: accommodate backward dependencies for wolfSSL_X509_NAME_add_entry_by_NID, wolfSSL_X509_NAME_free, and wolfSSL_X509_NAME_new_ex.
linuxkm/lkcapi_glue.c: if CONFIG_CRYPTO_MANAGER, assert match of CONFIG_CRYPTO_FIPS and HAVE_FIPS.
src/ssl_crypto.c, wolfcrypt/src/wc_lms.c, wolfcrypt/src/wc_lms_impl.c, wolfcrypt/src/wc_xmss.c, wolfcrypt/test/test.c: add missing casts for XMALLOC()s.
src/ssl_crypto.c: in wolfSSL_AES_decrypt(), fix gate for wc_AesDecryptDirect() return type.
wolfcrypt/test/test.c: smallstack refactor in test_dilithium_decode_level().
tests/api.c: fix uninited vars and "embedding a directive within macro arguments is not portable" in test_wc_dilithium_der().
douzzer
force-pushed
the
20241121-fixes
branch
from
85ceadd to
d85c108
Compare
Contributor
Author
|
retest this please (python port test "test_ssl failed") |
Contributor
Author
|
Note python test failure is unrelated to this PR. |
Member
|
FYI Test failure in on Python test. The PR Aidan and I did in wolfSSL/osp#211 clearly didn't work. I'll reproduce locally and get another patch put up. |
JacobBarthelmeh
approved these changes
Nov 22, 2024
Contributor
Author
|
@bigbrett yeah I had the definite feeling I was drag racing with you on those 😜 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfssl/wolfcrypt/error-crypt.h,wolfcrypt/src/error.c: addWC_FAILURE("wolfCrypt generic failure") with value-1, for traceable error return of-1in wolfCrypt.configure.ac: addOPENSSL_EXTRAto--enable-wolfsentry.linuxkm/linuxkm_wc_port.h,linuxkm/module_hooks.c,wolfssl/ssl.h: accommodate backward dependencies forwolfSSL_X509_NAME_add_entry_by_NID,wolfSSL_X509_NAME_free, andwolfSSL_X509_NAME_new_ex.linuxkm/lkcapi_glue.c: ifCONFIG_CRYPTO_MANAGER, assert match ofCONFIG_CRYPTO_FIPSandHAVE_FIPS.src/ssl_crypto.c,wolfcrypt/src/wc_lms.c,wolfcrypt/src/wc_lms_impl.c,wolfcrypt/src/wc_xmss.c,wolfcrypt/test/test.c: add casts forXMALLOC()s.src/ssl_crypto.c: inwolfSSL_AES_decrypt(), fix gate forwc_AesDecryptDirect()return type.wolfcrypt/test/test.c: smallstack refactor intest_dilithium_decode_level().tests/api.c: fix uninited vars intest_wc_dilithium_der().tested with
FIPS_DEV_BRANCH=local:20241121-WC_FAILURE-and-HAVE_EMBEDDED_AGENT wolfssl-multi-test.sh ... super-quick-check fips-140-3-v6-optest-acvp-sp-asm fips-140-3-ready-optest-acvp-sp-asm fips-140-3-dev-optest-acvp-sp-asm fips-140-3-dev-optest-acvp-sp-asm-trace-errcodes fips-140-3-dev-optest-acvp-sp-noasm fips-140-3-dev-optest-acvp-sp-asm-gcc-latest fips-140-3-dev-optest-acvp-sp-asm-gcc-latest-no-sha-1 fips-140-2-optest fips-140-2-openssl-all fips-140-3-pilot-all fips-140-3-pilot-optest-acvp-sp-asm fips-140-3-all linuxkm-all-fips-140-3 linuxkm-all-fips-140-3-dev-dyn-hash linuxkm-fips-dev-static-hash-intelasm-LKCAPI-insmod-crypto-fuzzer linuxkm-mainline-intelasm-sp-asm-pie-gcc-latest-insmod wolfssl-with-wolfsentry quantum-safe-wolfssl-all-noasm-stack-sizes