Python: skip test_parse_cert_CVE_2013_4238 under wolfSSL#333
Open
julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Open
Python: skip test_parse_cert_CVE_2013_4238 under wolfSSL#333julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
julek-wolfssl wants to merge 1 commit intowolfSSL:masterfrom
Conversation
wolfSSL now rejects NUL bytes in dNSName/rfc822Name/URI SAN entries during ASN.1 decoding (RFC 5280 4.2.1.6), so loading nullbytecert.pem raises ssl.SSLError instead of returning the SAN list with the embedded NULs preserved. Update the 3.12.11, 3.13.4, and 3.13.7 patches so the test asserts the SSLError and returns early, dropping the now-dead wolfSSL-specific SAN comparison branch.
Member
Author
|
Updates expected behaviour for wolfSSL/wolfssl#10279 |
There was a problem hiding this comment.
Pull request overview
Updates the wolfSSL-specific Python patch sets to reflect stricter SAN parsing behavior (wolfSSL now rejects embedded NUL bytes during ASN.1 decoding), aligning the affected CPython SSL test with the new behavior.
Changes:
- Update
test_parse_cert_CVE_2013_4238to assertssl.SSLErrorunder wolfSSL and return early. - Remove the now-obsolete wolfSSL-only SAN tuple comparison branch in that test across the maintained patch versions.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Python/wolfssl-python-3.13.7.patch | Adjusts test_parse_cert_CVE_2013_4238 to expect an SSLError under wolfSSL due to NUL-byte SAN rejection. |
| Python/wolfssl-python-3.13.4.patch | Same test adjustment as 3.13.7, applied to the 3.13.4 patch set. |
| Python/wolfssl-python-3.12.11.patch | Same test adjustment as 3.13.x, applied to the 3.12.11 patch set. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfSSL now rejects NUL bytes in dNSName/rfc822Name/URI SAN entries
during ASN.1 decoding (RFC 5280 4.2.1.6), so loading nullbytecert.pem
raises ssl.SSLError instead of returning the SAN list with the embedded
NULs preserved. Update the 3.12.11, 3.13.4, and 3.13.7 patches so the
test asserts the SSLError and returns early, dropping the now-dead
wolfSSL-specific SAN comparison branch.