Skip to content

Python: skip test_parse_cert_CVE_2013_4238 under wolfSSL #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
julek-wolfssl wants to merge 1 commit into
base: master
Choose a base branch
from
+39 −45
Open

Python: skip test_parse_cert_CVE_2013_4238 under wolfSSL #333

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 13 additions & 15 deletions Python/wolfssl-python-3.12.11.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,22 +454,20 @@ index b13e37d0cd1..6ca981aac04 100644
(('DNS', 'projects.developer.nokia.com'),
('DNS', 'projects.forum.nokia.com'))
)
@@ -465,7 +480,14 @@ def test_parse_cert_CVE_2013_4238(self):
(('emailAddress', 'python-dev@python.org'),))
self.assertEqual(p['subject'], subject)
self.assertEqual(p['issuer'], subject)
- if ssl._OPENSSL_API_VERSION >= (0, 9, 8):
@@ -453,6 +468,13 @@ def test_parse_cert_CVE_2019_5010(self):
)

def test_parse_cert_CVE_2013_4238(self):
+ if ssl.IS_WOLFSSL:
+ # location of email in list is different
+ san = (('IP Address', '2001:DB8:0:0:0:0:0:1'),
+ ('IP Address', '192.0.2.1'),
+ ('URI', 'http://null.python.org\x00http://example.org'),
+ ('DNS', 'altnull.python.org\x00example.com'),
+ ('email', 'null@python.org\x00user@example.org'))
+ elif ssl._OPENSSL_API_VERSION >= (0, 9, 8):
san = (('DNS', 'altnull.python.org\x00example.com'),
('email', 'null@python.org\x00user@example.org'),
('URI', 'http://null.python.org\x00http://example.org'),
+ # wolfSSL rejects NUL bytes in dNSName/rfc822Name/URI SAN entries
+ # during ASN.1 decoding (RFC 5280 4.2.1.6); the cert fails to parse
+ # rather than returning entries with the embedded NULs intact.
+ self.assertRaises(ssl.SSLError,
+ ssl._ssl._test_decode_cert, NULLBYTECERT)
+ return
p = ssl._ssl._test_decode_cert(NULLBYTECERT)
if support.verbose:
sys.stdout.write("\n" + pprint.pformat(p) + "\n")
@@ -483,7 +505,29 @@ def test_parse_cert_CVE_2013_4238(self):

def test_parse_all_sans(self):
Expand Down
28 changes: 13 additions & 15 deletions Python/wolfssl-python-3.13.4.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,22 +454,20 @@ index dfd5d2a..0658973 100644
# extra OCSP and AIA fields
self.assertEqual(p['OCSP'], ('http://ocsp.verisign.com',))
self.assertEqual(p['caIssuers'],
@@ -487,7 +501,14 @@ def test_parse_cert_CVE_2013_4238(self):
(('emailAddress', 'python-dev@python.org'),))
self.assertEqual(p['subject'], subject)
self.assertEqual(p['issuer'], subject)
- if ssl._OPENSSL_API_VERSION >= (0, 9, 8):
@@ -475,6 +489,13 @@ def test_parse_cert_CVE_2019_5010(self):
)

def test_parse_cert_CVE_2013_4238(self):
+ if ssl.IS_WOLFSSL:
+ # location of email in list is different
+ san = (('IP Address', '2001:DB8:0:0:0:0:0:1'),
+ ('IP Address', '192.0.2.1'),
+ ('URI', 'http://null.python.org\x00http://example.org'),
+ ('DNS', 'altnull.python.org\x00example.com'),
+ ('email', 'null@python.org\x00user@example.org'))
+ elif ssl._OPENSSL_API_VERSION >= (0, 9, 8):
san = (('DNS', 'altnull.python.org\x00example.com'),
('email', 'null@python.org\x00user@example.org'),
('URI', 'http://null.python.org\x00http://example.org'),
+ # wolfSSL rejects NUL bytes in dNSName/rfc822Name/URI SAN entries
+ # during ASN.1 decoding (RFC 5280 4.2.1.6); the cert fails to parse
+ # rather than returning entries with the embedded NULs intact.
+ self.assertRaises(ssl.SSLError,
+ ssl._ssl._test_decode_cert, NULLBYTECERT)
+ return
p = ssl._ssl._test_decode_cert(NULLBYTECERT)
if support.verbose:
sys.stdout.write("\n" + pprint.pformat(p) + "\n")
@@ -505,23 +526,45 @@ def test_parse_cert_CVE_2013_4238(self):

def test_parse_all_sans(self):
Expand Down
28 changes: 13 additions & 15 deletions Python/wolfssl-python-3.13.7.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,22 +454,20 @@ index 37766288a3c..ab4b915b75d 100644
# extra OCSP and AIA fields
self.assertEqual(p['OCSP'], ('http://ocsp.verisign.com',))
self.assertEqual(p['caIssuers'],
@@ -488,7 +502,14 @@ def test_parse_cert_CVE_2013_4238(self):
(('emailAddress', 'python-dev@python.org'),))
self.assertEqual(p['subject'], subject)
self.assertEqual(p['issuer'], subject)
- if ssl._OPENSSL_API_VERSION >= (0, 9, 8):
@@ -476,6 +490,13 @@ def test_parse_cert_CVE_2019_5010(self):
)

def test_parse_cert_CVE_2013_4238(self):
+ if ssl.IS_WOLFSSL:
+ # location of email in list is different
+ san = (('IP Address', '2001:DB8:0:0:0:0:0:1'),
+ ('IP Address', '192.0.2.1'),
+ ('URI', 'http://null.python.org\x00http://example.org'),
+ ('DNS', 'altnull.python.org\x00example.com'),
+ ('email', 'null@python.org\x00user@example.org'))
+ elif ssl._OPENSSL_API_VERSION >= (0, 9, 8):
san = (('DNS', 'altnull.python.org\x00example.com'),
('email', 'null@python.org\x00user@example.org'),
('URI', 'http://null.python.org\x00http://example.org'),
+ # wolfSSL rejects NUL bytes in dNSName/rfc822Name/URI SAN entries
+ # during ASN.1 decoding (RFC 5280 4.2.1.6); the cert fails to parse
+ # rather than returning entries with the embedded NULs intact.
+ self.assertRaises(ssl.SSLError,
+ ssl._ssl._test_decode_cert, NULLBYTECERT)
+ return
p = ssl._ssl._test_decode_cert(NULLBYTECERT)
if support.verbose:
sys.stdout.write("\n" + pprint.pformat(p) + "\n")
@@ -506,23 +527,45 @@ def test_parse_cert_CVE_2013_4238(self):

def test_parse_all_sans(self):
Expand Down