F-580 zeroed out password field at end of function#230
Open
aidankeefe2022 wants to merge 1 commit into
Open
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #230
Scan targets checked: wolfclu-bugs, wolfclu-src
No new issues found in the changed files. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the wolfCLU_RSA command implementation to wipe the in-memory password buffer before the function returns, reducing the chance of sensitive data lingering in process memory.
Changes:
- Zero the
passwordstack buffer viawolfCLU_ForceZero(password, MAX_PASSWORD_SIZE)on the normal function exit path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+298
to
301
| wolfCLU_ForceZero(password, MAX_PASSWORD_SIZE); | ||
| wolfSSL_BIO_free(bioIn); | ||
| wolfSSL_BIO_free(bioOut); | ||
| wolfSSL_RSA_free(rsa); |
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #230
Scan targets checked: wolfclu-bugs, wolfclu-src
No new issues found in the changed files. ✅
Member
Author
|
added zero out code at help function early return case in the wolfCLU_RSA function |
aidankeefe2022
force-pushed
the
fix-password-not-zeroed
branch
from
959725d to
7ba7a64
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
password field was not zeroed out in the wolfCLU_RSA function before the function returned now it is but calling wolfCLU_ForceZero on the char array.