Skip to content

bump default bigbufsize for mldsa builds - #402

Merged
padelsbach merged 2 commits into
wolfSSL:mainfrom
bigbrett:mldsa-default-bufsize
Jun 4, 2026
Merged

bump default bigbufsize for mldsa builds#402
padelsbach merged 2 commits into
wolfSSL:mainfrom
bigbrett:mldsa-default-bufsize

Conversation

@bigbrett

@bigbrett bigbrett commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Follow up to #397 to make the defaults usable

  • autosize default big cache buffer size if MLDSA is enabled
  • remove custom example/test/bench big cache buffer sizes and rely on defaults that should now work based on algo selection

Copilot AI review requested due to automatic review settings June 4, 2026 15:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the wolfHSM default server “big” key-cache buffer sizing so builds that enable ML-DSA automatically use a sufficiently large default buffer, preventing ML-DSA keypair caching failures without requiring per-port overrides.

Changes:

  • Make WOLFHSM_CFG_SERVER_KEYCACHE_BIG_BUFSIZE default conditional on WOLFSSL_HAVE_MLDSA.
  • Increase the default “big” key-cache buffer size to 8192 when ML-DSA is enabled (retaining 1200 otherwise).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@padelsbach
padelsbach merged commit 7972967 into wolfSSL:main Jun 4, 2026
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants