Implement HMAC-SHA3 benchmarks (224/256/384/512) - #501
Open
kojiws wants to merge 1 commit into
Open
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #501
No scan targets match the changed files in this PR. Review skipped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the HMAC-SHA3 benchmarks in
benchmark/bench_modules/wh_bench_mod_hmac.c, which were stubs returningWH_ERROR_NOTIMPLand silently-> SKIPPED. Covers all four variants(224/256/384/512), DMA and non-DMA. Entries switched from
BENCH_THROUGHPUT_NONEtoXBPSso throughput is reported.wolfHSM has no HMAC server handler, so the ipad/opad construction runs
client-side; only the inner SHA3 compressions are offloaded. Same as the
existing HMAC-SHA2-256 benchmark — the number is HMAC as seen by the client.
Test
make DMA=1: all eight rows report; previously two wereSKIPPEDand sixdid not exist.
make(non-DMA): the four non-DMA rows report.Not verified: digest correctness. Unlike SHA3, the repository has no HMAC
test coverage at all, so nothing backs these values beyond the SHA3 KATs
covering the inner hash.